search

rpm-software-management / urlgrabber

GNU Lesser General Public License v2.1
14 stars 23 forks source link

Cleaned the untidy mess in setup.py #21

Closed KOLANICH closed 5 years ago

KOLANICH commented 5 years ago

Fixes: #20

Conan-Kudo commented 5 years ago

@KOLANICH where's the version set?

KOLANICH commented 5 years ago

The latest git tag on the branch is a version. It should look like a version.

Conan-Kudo commented 5 years ago

@KOLANICH The version needs to be correctly propagated into the code, as it's used in a couple of places there. Also, how will this work if someone uses a github archive?

KOLANICH commented 5 years ago

The version needs to be correctly propagated into the code

It is possible to parse it from the metadata using pkg_resources.

Also, how will this work if someone uses a github archive?

No, since it is taken from git. If an archive doesn't contain whole git repo with .git dir, or if there is no git in the system where build is done, it will fail hard. Though IMHO it is not an issue: git is present in all devs` machines today.

Conan-Kudo commented 5 years ago

Mandating git as a build dependency is not acceptable. Sorry. That said, I do have an alternative fix that I can push.