search

rqlite / gorqlite

A Go client for rqlite, the distributed database built on SQLite
MIT License
139 stars 34 forks source link

basic support for prepared statements #18

Open marctrem opened 2 years ago

marctrem commented 2 years ago

Please let me know if you like this so I can polish it.

otoolep commented 2 years ago

Yes, thanks -- this functionality is definitely welcome.

otoolep commented 1 year ago

The original author indicated there would be more "polish" to come, so I didn't merge it yet. I would need to examine the code, and determine if it's ready for merging (and that sufficient testing has been put in place).

Is there anyone interested in doing that?

sgalsaleh commented 1 year ago

@otoolep It looks like the author has marked the PR as "ready for review", so I assume that the polishing is done? I can also see that tests have been added. I'm not sure if the author is still active, but if further changes need to me made, I'd be happy to make them and submit a separate PR.

gandaldf commented 1 year ago

If you want, take a look at my repo: https://github.com/gandaldf/gorqlite

sgalsaleh commented 1 year ago

@gandaldf thank you for the suggestion, I'm about to submit a PR soon of my own with support for both parameterized statements and nullable types. If you're interested, this is how it looks like now: https://github.com/replicatedhq/gorqlite/pull/1