search

rqlite / gorqlite

A Go client for rqlite, the distributed database built on SQLite
MIT License
139 stars 34 forks source link

Add time.Time support for QueryResult.Scan #8

Closed paulstuart closed 4 years ago

paulstuart commented 4 years ago

Allow direct support for using time.Time values with rqlite. Type conversion was extended to be more forgiving of input and more descriptive in errors. Tests were added for the changes.

otoolep commented 4 years ago

Can you please merge master? I just enabled CircleCI testing, so would like this PR to run the tests before merging.

paulstuart commented 4 years ago

I can't merge master here, but I just did a push (an empty line was deleted)

paulstuart commented 4 years ago

@otoolep did that second merge trigger your CI/CD?

otoolep commented 4 years ago

I don't see any merge from master in the commit history: https://github.com/rqlite/gorqlite/pull/8/commits

otoolep commented 4 years ago

You must merge the upstream master into your branch.

otoolep commented 4 years ago

image

Your master is 13 commits behind my master.

paulstuart commented 4 years ago

Oops. Kinda new to PRs from forks :-)

otoolep commented 4 years ago

It still doesn't look right. Perhaps you should close this PR, and create a new PR with just your changes. Make sure your fork's master is the same as upstream first.

paulstuart commented 4 years ago

Fair enough. Sorry for the confusion. I'll be back!