search

rsd-devel / rsd

RSD: RISC-V Out-of-Order Superscalar Processor
Apache License 2.0
934 stars 95 forks source link

Fix license information so GitHub detects it correctly #8

Closed mithro closed 4 years ago

mithro commented 4 years ago

Fixes #7 .

See the following screenshots;

Screenshot from 2020-01-14 14-43-49

Screenshot from 2020-01-14 14-45-08

shioyadan commented 4 years ago

Thanks for your fix. I was also wondering why the LICENSE file was not recognized correctly, but did not notice that there was an unnecessary blank line.

The THIRD-PARTY-LICENSES file is now empty, but we will update it in the near future as we add some benchmarks (ex. Core Mark) to the repository. So, could you recover it?

mithro commented 4 years ago

@shioyadan I think the detection is /actually/ getting confused by you having multiple files with LICENSE in the name. The recommended approach for including third party stuff into your project is to create a third_party directory and include the information under that. You can see how Google recommends their engineers organize repositories at https://opensource.google/docs/releasing/preparing/#third-party-components

shioyadan commented 4 years ago

Thank you for your explanation. I understand the situation. I will put third-party related files to another place. I will merge your pull request soon. Thanks!

mithro commented 4 years ago

@shioyadan Looks like it is all working now! Thanks.