fix: replace it-all library and refactor tests

rsksmart / rif-data-vault

RIF Data Vault

MIT License

2 stars 7 forks source link

fix: replace it-all library and refactor tests #104

Closed dvrosalesm closed 2 years ago

dvrosalesm commented 2 years ago

Fix for solving the issue of commas being added to large pinned contents.

Context: There was an issue when uploading files bigger than 5KB, after pinning them in IPFS and then retrieving the content it was returned with commas added in between.

Fix: We narrowed the problem down to a external library "it-all" and replaced it with the implementation mentioned in one of the ipfs-js kb that doesn't require an external library.

sergio-jara commented 2 years ago

looks good. It would be nice if you add some comments on the description pointing out what was the issue and how you approached the solution.