rtCamp / wp-menu-custom-fields

An example of custom fields for menu in WordPress 5.4+
https://wordpress.org/plugins/wp-menu-custom-fields/
16 stars 5 forks source link

Test plugin with WordPress and PHP latest versions. #51

Closed pooja-muchandikar closed 2 years ago

pooja-muchandikar commented 2 years ago

@alvitazwar Perform thorough testing of WP Menu Custom Fields v1.0.2 plugin with WordPress 6.0.2 and PHP 8.1 version and report issues for same.

Refer these test cases: https://docs.google.com/spreadsheets/d/1SUyVZsr0hsj9Wpt3pnYpPjgb68fMMj2sgA5MjTTGOw0/edit#gid=846109294

Create new test cases if required and add to same test cases.

Make sure you cover following points:

Share updates in comments..

cc: @SonaliThakkar25

SonaliThakkar25 commented 2 years ago

@alvitazwar Also Check if the basic UI is there or not, means if some other user installing the plugin then things should look good when rendered because plugin usually inherit the default styles. cc: @pooja-muchandikar

alvitazwar commented 2 years ago

@SonaliThakkar25 Okay I will check that.

alvitazwar commented 2 years ago

This testing is also completed in develop branch

alvitazwar commented 2 years ago

Update: Only for adding audio shortcode, In local, using PHP 8.0, getting Fatal error. So please fix it on feature/GH-82 branch.

Screenshot at Oct 17 16-25-08

CC: @shreyasikhar @SonaliThakkar25

shreyasikhar commented 2 years ago

@alvitazwar This is ready for review. To test, switch to PHP version 8.x.x and clone the branch feature/GH-51

cc: @SonaliThakkar25

alvitazwar commented 2 years ago

@shreyasikhar I am seeing that, feature/GH-51 fixed the fatal error problem, but the design seems to be not fixed. can you please sync the design fixes from feature/GH-82 and sync it to develop? Rest looks fine to me

Screenshot at Oct 17 17-26-31
shreyasikhar commented 2 years ago

@alvitazwar The feature/GH-51 and feature/GH-82 PRs are still waiting on approval, will update once it is merged.

alvitazwar commented 2 years ago

Thanks for the update

shreyasikhar commented 2 years ago

@alvitazwar PHP fatal error issue is fixed on develop, let me know if all looks good to merge it in master. Thanks.

alvitazwar commented 2 years ago

I cross-checked develop branch with the fixes and It seems to be fixed and ready to push on master

shreyasikhar commented 2 years ago

@alvitazwar PHP fatal error issue is fixed on master as well.

cc: @SonaliThakkar25

alvitazwar commented 2 years ago

This issue is fixed and working fine on master, Hence closing this issue.