search

rtCamp / wp-menu-custom-fields

An example of custom fields for menu in WordPress 5.4+
https://wordpress.org/plugins/wp-menu-custom-fields/
16 stars 5 forks source link

UI: If video is added as sub menu then UI design looks inconsistent. #59

Closed alvitazwar closed 2 years ago

alvitazwar commented 2 years ago

When the User Adds a video as the submenu item then in the front end the item appears with vast empty space.

Steps: Add a menu Add a submenu Add video using shortcode in the submenu. See the changes in the front-end

SS:https://prnt.sc/2oAwUFH9X-5V

alvitazwar commented 2 years ago

@shreyasikhar Tomorrow when you start your day, please take this issue as first priority

shreyasikhar commented 2 years ago

@alvitazwar This is ready for review. To test, please clone from branch feature/GH-59 and let me know if any feedback.

cc: @SonaliThakkar25

alvitazwar commented 2 years ago

In the twenty-twenty-one:

video-2021

twenty-twenty:

video 2020

Both the cases' design looks fine to me. Please merge it with develop so that I can perform quick testing for all the issues

shreyasikhar commented 2 years ago

Thanks @alvitazwar for the review. I think the issue #65 is similar to this, so we should have both the issues fixed in the branch feature/GH-59 @alvitazwar Can you please confirm this, thanks.

cc: @SonaliThakkar25

alvitazwar commented 2 years ago

@shreyasikhar I tested https://github.com/rtCamp/wp-menu-custom-fields/issues/65 and both issues fixes are working as expected in the feature/GH-59 branch

shreyasikhar commented 2 years ago

This is also fixed on master branch. cc: @alvitazwar @SonaliThakkar25

alvitazwar commented 2 years ago

This issue is fixed and working fine on master, Hence closing this issue.