rtCamp / wp-menu-custom-fields

An example of custom fields for menu in WordPress 5.4+
https://wordpress.org/plugins/wp-menu-custom-fields/
16 stars 5 forks source link

UI: twenty-twenty-one theme Image link submenu option UI enhancement #64

Closed alvitazwar closed 2 years ago

alvitazwar commented 2 years ago

In the twenty-twenty theme, the design looks perfect when the user adds an image_link in the front end. We can follow and implement the same image and text alignment enhancement in the twenty-twenty-one theme.

backend configuration: https://prnt.sc/1b0ThEqCDbka twenty-twenty design: https://prnt.sc/wng21Efl_Vjb twenty-twenty-one design: https://prnt.sc/Invb67KqN0kN

CC: @SonaliThakkar25

shreyasikhar commented 2 years ago

@alvitazwar This is ready for review. To test, please clone from branch feature/GH-64 and let me know if any changes required.

cc: @SonaliThakkar25

alvitazwar commented 2 years ago

@shreyasikhar I pulled the feature/GH-64 branch and tested the fixes in my local.

In the twenty-twenty theme :

imageLink-2020

in the twenty-twenty-one theme:

Image-link-2021

now The design looks more consistent and polished than before. Great Work @shreyasikhar.

shreyasikhar commented 2 years ago

This issue is fixed in the develop branch. Will update it on master once video shortcode related issue gets fixed (expecting a fix PR today itself).

alvitazwar commented 2 years ago

@SonaliThakkar25 This Issue is fixed in develop branch. So after fixing all other issues. We can merge it with master in sometime.

shreyasikhar commented 2 years ago

This is also fixed on master branch. cc: @alvitazwar @SonaliThakkar25

alvitazwar commented 2 years ago

This issue is fixed and working fine on master, Hence closing this issue.