rtCamp / wp-menu-custom-fields

An example of custom fields for menu in WordPress 5.4+
https://wordpress.org/plugins/wp-menu-custom-fields/
16 stars 5 forks source link

Final Round of Testing #78

Closed SonaliThakkar25 closed 2 years ago

SonaliThakkar25 commented 2 years ago

@alvitazwar,

Let's perform the final round of testing by keeping in mind the following things:

  1. The issues we faced
  2. Responsive
  3. Cross Browser
  4. Cross Theme checks
alvitazwar commented 2 years ago

Update: I pulled the develop branch in my local and dev site and test different themes today, Here is my observations:

CC: @SonaliThakkar25

shreyasikhar commented 2 years ago

@SonaliThakkar25 I checked the above feedbacks from @alvitazwar and found out that these bugs that are coming in above mentioned themes because of css styles written in their own themes and overwriting our plugin's css.

We cannot write css to fix UI on all the themes, ideally these should be done from the respective themes only. If we tried to fix these bugs from the plugin, then this changes may affect on other themes badly.

SonaliThakkar25 commented 2 years ago

@shreyasikhar Agree!!! @alvitazwar You can make your final thoughts here

alvitazwar commented 2 years ago

I also agree with @shreyasikhar. We can ignore the theme wise fix..as different themes will have different css. So lets keep it for now and move forward with release.

alvitazwar commented 2 years ago

Today's Update:

  1. Perform testing on WordPress 6.0.3 with default themes
  2. Cross-check readme file and description.
  3. Perform sanity testing with updated zip

NB: Will close this task once release is completed. CC: @SonaliThakkar25