search

rtklibexplorer / RTKLIB

A version of RTKLIB optimized for low cost GNSS receivers, especially u-blox receivers. It is based on RTKLIB 2.4.3 and is kept reasonably closely synced to that branch. This software is provided “AS IS” without any warranties of any kind so please be careful, especially if using it in any kind of real-time application.
http://rtkexplorer.com/
Other
607 stars 238 forks source link

Qt gui setPath: rework, correct #347

Closed ourairquality closed 1 month ago

ourairquality commented 1 month ago

This is https://github.com/rtklibexplorer/RTKLIB/pull/303 rebased cleanly to demo5. Sorry if this is an unwelcome dup but it was closed without comment and there are issues here, so please just close it again if not interested.

Follow the logic in src/stream.c decodetcppath() to be consistent.

Update getPath() to only return those components available. It no longer tacks on a ':' separator for the STR component is there is none, or other unnecessary separators.

There might still be further issues with the presentation of the STR component for ntrip servers and casters.

JensReimann commented 1 month ago

Sorry for closing the old PR. There were some comments from my side on the original PR and therefore it was not instantly merged. A side effect of closing the whole qt_gui branch after the merge into demo5 was that all remaining PR were automatically closed, which was not intended. Thanks for recommitting the changes. Please see my comments on the new PR.

ourairquality commented 1 month ago

Had integrated the suggestion to use path += "@".