search

rtklibexplorer / RTKLIB

A version of RTKLIB optimized for low cost GNSS receivers, especially u-blox receivers. It is based on RTKLIB 2.4.3 and is kept reasonably closely synced to that branch. This software is provided “AS IS” without any warranties of any kind so please be careful, especially if using it in any kind of real-time application.
http://rtkexplorer.com/
Other
603 stars 236 forks source link

rtkpost_qt demo5 b34j Base Station X/Y/Z-ECEF are not converted to Lat/Lon/Heigth (deg/m) #397

Closed qgis2000 closed 4 days ago

qgis2000 commented 1 week ago

In Options..., Positions tab, I have the base station coordinates in the X/Y/Z-ECEF format. When I change the format to Lat/Lon/Heigth (deg/m) then Lat=-90.000000000 ° and Lon=0.000000000 °

JensReimann commented 1 week ago

This is related to #396

qgis2000 commented 1 week ago

I can change the format and coordinates are calculated in new format but... there is such a case: I enter the coordinates of the base station in the X/Y/Z-ECEF format. Then I switch the format to Lat/Lon/Height (dms/m) and it's ok. Then I return to the X/Y/Z-ECEF format and the coordinates are converted correctly but displayed with a space as the thousands spearator, which is correct. Now, however, when I switch to the Lat/Lon/Height (dms/m) format, Lat=-90° 0' 0.000000" Lon=0° 0' 0.000000" appear.

qgis2000 commented 1 week ago

When base station coordinates X/Y/Z-ECEF format is set and the coordinates are with group separator (thousands separator) calculations are not performed.

JensReimann commented 1 week ago

I made the input validation respect the system localisation. Please test if this fixes the problem for you.

qgis2000 commented 1 week ago

Now works when: a) there is no group separator in coordinates, b) all group separators are in coordinates. However, if I remove even one space (group separator) from any of the coordinates, rtkpost does not perform the calculations. Also, when I remove a space, I can no longer type it again.

I do not demand localization of the program. It may or may not be. I'm just reporting a problem.

JensReimann commented 1 week ago

The Qt GUI is specially designed to be easy for users. This includes localization.

The latest update does not use self-written regular expressions anymore, but use standard validations. Additionally, invalid inputs are highlighted and the format cannot be changed anymore if the input is not valid. This should prevent users from losing their inputs.

qgis2000 commented 1 week ago

Ok. Invalid inputs are in red and then rtkpost calculatins are not performed (Q=0). Change of format works. Thank you.