rubyforgood / applied-conservation

MIT License
7 stars 17 forks source link

Clean up specs - lets vs instance variables #64

Closed jtwhittington closed 6 years ago

jtwhittington commented 6 years ago

We should decide on if we are using lets or before blocks for our specs...

This article makes an argument for using lets unless it is a before_all block (https://www.ombulabs.com/blog/rails/rspec/ruby/let-vs-instance.html)

Convert all @instance_variables in before blocks to lets