Changed column from percent_filled to corals_added

LizPrescott commented 4 years ago

Resolves some of #80 . Happy to rebase after the related pr is merged too.

Description

On our last call with the Coral Gardeners, they clarified that they do not want to log the percent of a table filled when they are on a dive. They merely want to log the number added and removed. This pr just does the number added because someone else is doing number_removed

Type of change

New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected) - The i18n will need an update.

cflipse commented 4 years ago

Looks good, but can you add the missing i18n translation so the tests be happy?

LizPrescott commented 4 years ago

Looks good, but can you add the missing i18n translation so the tests be happy?

Ah yes. Will do!

LizPrescott commented 4 years ago

Can we exclude the schema file from rubocop pretty please?

cflipse commented 4 years ago

it ... already is?

Lemme poke around the rubocop config, something else might be happening.

rubyforgood / coral

Changed column from percent_filled to corals_added #87

Description

Type of change