search

runejs / server

RuneJS is a RuneScape game server written in TypeScript and JavaScript. The goal of the project is to create a comprehensive game engine, while also providing simple and easy to use content development systems and APIs.
GNU General Public License v3.0
244 stars 83 forks source link

Add rune armor items #355

Closed RedSparr0w closed 3 years ago

RedSparr0w commented 3 years ago

Add rune armor items Add rune god armor items

Promises commented 3 years ago

Thanks! I've approved the PR, even though the quest requirements for the platebodies is missing because we don't have the actual quest in the server yet.

if you make a note of that, i can probably set it up to check if a quest exists, if not it will allow

RedSparr0w commented 3 years ago

Completely forgot the platebody had a quest requirement 😅

Promises commented 3 years ago

I might be wrong, but rune gloves might also be locked behind some special cases related to RFD

SchauweM commented 3 years ago

Thanks! I've approved the PR, even though the quest requirements for the platebodies is missing because we don't have the actual quest in the server yet.

if you make a note of that, i can probably set it up to check if a quest exists, if not it will allow

That might actually be a better solution. Do you want me to close this PR or do you want to add the functionality to it in this PR?

RedSparr0w commented 3 years ago

I believe the rune gloves don't have any hard requirements other than the fact you can't obtain them before completing the quest. Although they should be non-tradable.

Promises commented 3 years ago

Thanks! I've approved the PR, even though the quest requirements for the platebodies is missing because we don't have the actual quest in the server yet.

if you make a note of that, i can probably set it up to check if a quest exists, if not it will allow

That might actually be a better solution. Do you want me to close this PR or do you want to add the functionality to it in this PR?

close this one, but make a note or send me a message on discord in a few hours, and ill work on it separately