refactor: convert firemaking task to use new task system

runejs / server

RuneJS is a RuneScape game server written in TypeScript and JavaScript. The goal of the project is to create a comprehensive game engine, while also providing simple and easy to use content development systems and APIs.

GNU General Public License v3.0

238 stars 82 forks source link

refactor: convert firemaking task to use new task system #383

Closed Jameskmonger closed 1 year ago

Jameskmonger commented 1 year ago

This PR ports the old Firemaking plugin to use the tick-based task system

It's ready for merge, but there are a few things that we can improve in future:

Support right-click "Light" on logs
Check that the player still has a Tinderbox in their inventory at time of light (this might be handled by the "drop" code, so will leave this for now)
Document/remove the canChain code, I can't see anything about it on OSRS wiki etc.