search

rupeshs / fastsdcpu

Fast stable diffusion on CPU
MIT License
1k stars 87 forks source link

Minor changes to tiled upscale code #134

Closed monstruosoft closed 4 months ago

monstruosoft commented 4 months ago

This commit attempts to honor tiled upscale JSON settings for output format, source file, etc.. Both CLI arguments and JSON settings should work; if both are present, JSON settings override CLI arguments.

Also, it's now possible to define a top level prompt for tiled upscale either by using the --prompt CLI argument or a top level prompt in JSON settings that must be present even if set to null. I realized that sometimes using promptless image variations for tiled upscale may result in completely disjointed tiles; providing a top level prompt might improve tile consistency, usually the same prompt used to generate the original image would work.

monstruosoft commented 4 months ago

That's why I left the value of 0.3 for OpenVINO but I thought you could allow for other values when using LCM models; I think it's better if you can set the strength via the --strength argument, you could also set a default value of 0.1 in the CLI arguments definition so that the user can override that value if he wants to. You have the last word.