search

rushisangani / RSSelectionMenu

An elegant selection list or dropdown menu for iOS with single or multiple selections.
MIT License
351 stars 91 forks source link

Missing Done button in 6.1.0 #103

Closed norbdev closed 4 years ago

norbdev commented 4 years ago

RSSelectionMenu.swift line 473

        // add done action
        if (tableView?.selectionStyle == .multiple || !self.dismissAutomatically || style == .actionSheet)  {
            if case .actionSheet = menuPresentationStyle {
                alertController.addAction(doneAction)
            }
        }
rushisangani commented 4 years ago

@norbdev What's the issue here? Can you elaborate?

norbdev commented 4 years ago

If you want an .alert not an .actionSheet the done action missing.

pmaattanen commented 4 years ago

The AlertAction style is set to .cancel in library. That is the reason why it doesn't show the button in iPads. when selection style is set to actionSheet (might be the case in .alert as well). Just change it to .default.

rushisangani commented 4 years ago

@norbdev Maybe the done button is not required in the iPad?

norbdev commented 4 years ago

In the 7.0.0 the issue is the same

https://github.com/rushisangani/RSSelectionMenu#presentation-style---formsheet-popover-alert-actionsheet

// or specify alert button title selectionMenu.show(style: .alert(title: "Select", action: "Done", height: nil), from: self)

The action Done is missing.

This commit is the issue: https://github.com/rushisangani/RSSelectionMenu/commit/c84630e66e1f2189b4553546f914624697a8b935

rushisangani commented 4 years ago

@norbdev @pmaattanen Thanks for reporting the issue and supporting this library. It's fixed now. Please update to version v.7.1.0.

https://github.com/rushisangani/RSSelectionMenu/releases/tag/v7.1.0

Thanks