rust-lang / rls

Repository for the Rust Language Server (aka RLS)
Other
3.51k stars 257 forks source link

Only show suggested code when it is non-empty #1742

Closed camelid closed 3 years ago

camelid commented 3 years ago

This is to match rustc's behavior, and to avoid weird diagnostic boxes that look like this:

unnecessary trailing semicolons

note: `#[warn(redundant_semicolons)]` on by default
help: remove these semicolons: ``

After this change, the last line should look like this:

help: remove these semicolons
Xanewok commented 3 years ago

Looks good, thanks!