search

rust-lang / rls

Repository for the Rust Language Server (aka RLS)
Other
3.53k stars 257 forks source link

Bump cargo version #1767

Closed weihanglo closed 2 years ago

weihanglo commented 2 years ago

In rust-lang/cargo@7248f4b70da464b9ed7839e0f26110b6664b6ee6, cargo::core::resolver::resolve::Resolve::extern_crate_name was renamed to extern_crate_name_and_dep_name and started to return both extern crate and dep name. RLS only needs extern crate name at this moment.

Not sure if there is any crate using rls as a libbrary directly. I assume no, so I change the type of the pub field Dep.crate_name. If this is not appropriate, I can alternatively keep it as String.

weihanglo commented 2 years ago

@ehuss May you help review this? Thanks!

Xanewok commented 2 years ago

Sorry for the lag, looks good. Thanks for the ping and the PR!