search

rust-lang / rls

Repository for the Rust Language Server (aka RLS)
Other
3.52k stars 257 forks source link

Fix tests including dead code warnings #1780

Closed TaKO8Ki closed 2 years ago

TaKO8Ki commented 2 years ago

This patch is related to https://github.com/rust-lang/rust/pull/97853. In it, I made some changes to collapse multiple dead code warnings into a single diagnostic. They broke some tests in cargo. After https://github.com/rust-lang/rust/pull/97853 is merged, this PR should be merged.

TaKO8Ki commented 2 years ago

https://github.com/rust-lang/rust/pull/97853 was merged. After a nightly including it is released, this PR should be merged.

TaKO8Ki commented 2 years ago

Nightly version is still not latest.

Mark-Simulacrum commented 2 years ago

Closing -- this has landed on master now in https://github.com/rust-lang/rls/commit/ece09b88c0365947af79c0ffdeea02bc6c1eec25.

See https://github.com/rust-lang/rust/pull/98488, https://github.com/rust-lang/rust/pull/97853#issuecomment-1166295123 for context.