Closed nyancol closed 6 years ago
Two variables that might have to be recalibrated are:
hapycolor.filters.reducer.Reducer.get_maximum_clique()
fixes the largest connected graph to 60, but maybe on some computers it could be too large and so, it would be too slow.hapycolor.filters.reducer.Reducer.threshold
defines the minimal distance between two colors. To calibrate this value, the easier way would be to uncomments the prints of this test: tests.test_reducer.TestReducer.test_reducer_taipei
and run python3 -m unittest tests.test_reducer.TestReducer.test_reducer_taipei
I tried to improve the coding style in various files. Maybe you had something more specific in mind?
This pull request contains:
Currently, the class that filters the luminosities and saturations is called
LumFilter
, which is not really appropriate. Any better ideas? I would like to avoid using the term "filter" since it is also a builtin python function. I don't expect you to read all the code added, but at leasttests/test_reducer.py
andtests/test_lum_filter.py
, which reflects more the capabilities of the new filters. To run an individual test:python3 -m unittest tests.test_reducer.TestReducer.test_reducer_taipei