search

rwbr / flutter_neat_and_clean_calendar

Simple and clean flutter calendar with ability to slide up/down to show weekly/monthly calendar. Forked from [flutter_clean_calender](https://pub.dev/packages/flutter_clean_calendar)
MIT License
104 stars 51 forks source link

[Feature Request] Allow for providing a default day color #34

Closed eugenedina closed 2 years ago

eugenedina commented 2 years ago

When viewing the expanded calendar, there doesn't seem to be a way the color for days within a month, but not the selected day. I'd like to propose providing a property on calendar that is passed down to the tile to provide this. I have made the necessary changes on my fork and can create a pull request if you'd like.

Because of my dark theme, the calendar ends up looking like this, making it very hard to read. image

This property would allow me to customize it as such. image

May not be a bad idea to also introduce a var for the default gray used for previous and next months' days.

rwbr commented 2 years ago

I get you point. Should be easy to fix. You contribution is highly welcome. Please share your code.

BTW: The more color option the package supports, the more it might be a good move to use something like a dedicated ThemeData object to configure these settings.

eugenedina commented 2 years ago

Excellent. I'll issue a pull request. I'll also make the changes for the default grey for non month days, if that's ok. Completely agree on ThemeData for a longer term solution. I've settled on this calendar for my project, so I'm invested in it now :) I'm happy to also work on this longer term solution.

rwbr commented 2 years ago

Closed with #35