rxseger
commented
8 years ago ~ $ brew audit --strict --online gr-osmosdr
rxseger/hackrf/gr-osmosdr:
* A `test do` test block should be added
* Head-only (no stable download)
* Formula should have a desc (Description).
* swig dependency should be
depends_on "swig" => :build
Or if it is indeed a runtime dependency
depends_on "swig" => :run
* "Formula.factory(name)" is deprecated in favor of "Formula[name]"
* `require 'formula'` is now unnecessary
* Use `system 'make", "install'` instead of `system 'make install'`
* python modules have explicit framework links
These python extension modules were linked directly to a Python
framework binary. They should be linked with -undefined dynamic_lookup
instead of -lpython or -framework Python.
/usr/local/Cellar/gr-osmosdr/HEAD/lib/python2.7/site-packages/osmosdr/_osmosdr_swig.so
* C: 1: col 9: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
* C: 4: col 12: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
* C: 5: col 8: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
* C: 5: col 55: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
* C: 6: col 5: Align the elements of a hash literal if they span more than one line.
* C: 8: col 14: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
* C: 9: col 14: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
* C: 10: col 14: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
* C: 11: col 14: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
* C: 12: col 14: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
* C: 13: col 14: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
* C: 14: col 14: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
* C: 17: col 11: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
* C: 18: col 14: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
* C: 18: col 23: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
* C: 19: col 14: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
* C: 20: col 14: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
* C: 25: col 30: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
* C: 26: col 65: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Error: 27 problems in 1 formula
~ $
gnuradio and librtlsdr are in homebrew-core, would be ideal if these could be upstreamed, too (at least gr-osmosdr, which depends on gr-baz), so this separate tap is not needed.
Need to review these formulae vs the Formula Cookbook.
The main problem appears to be gr-osmosdr and gr-baz are installed from
master, instead of a stable revision (is there any? will there be?):