search

rydmike / flex_color_picker

A highly customizable Flutter color picker.
BSD 3-Clause "New" or "Revised" License
200 stars 42 forks source link

add secondaryOffset #52

Closed danReynolds closed 2 years ago

danReynolds commented 2 years ago

The latest version of Flutter master will require the addition of this secondaryOffset parameter. Not needed for now on stable but should be helpful to note for folks in the future.

rydmike commented 2 years ago

Thanks @danReynolds, I noticed as well when I was in on master yesterday that something new will be needed, but did not look into it yet.

Thanks for the PR, really appreciate it. I will look at it and merge it a bit later. Feeling a bit under the weather at the moment. Got Covid diagnosis confirmed today, despite 3 vaccine shots. Very mild symptoms so far, guess the shots are to be thanked for that.

Focusing on code seems tiring and increases my headache. Hope to be back to full speed soon though.

danReynolds commented 2 years ago

Thanks @danReynolds, I noticed as well when I was in on master yesterday that something new will be needed, but did not look into it yet.

Thanks for the PR, really appreciate it. I will look at it and merge it a bit later. Feeling a bit under the weather at the moment. Got Covid diagnosis confirmed today, despite 3 vaccine shots. Very mild symptoms so far, guess the shots are to be thanked for that.

Focusing on code seems tiring and increases my headache. Hope to be back to full speed soon though.

Sorry to hear that you're under the weather. Speedy recovery! Take your time with the PR, no rush.

codecov-commenter commented 2 years ago

Codecov Report

Merging #52 (2e3f9b3) into master (6af74ef) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   65.56%   65.56%           
=======================================
  Files          23       23           
  Lines        2053     2053           
=======================================
  Hits         1346     1346           
  Misses        707      707
Impacted Files Coverage Δ
lib/src/widgets/opacity/opacity_slider_track.dart 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.