Fix gfortran compiler warnings

conradtchan commented 3 months ago

Fix all issues causing gfortran compiler warnings when doing make debug, and add a CI action to detect new warnings. The compiler-warnings action will fail if warnings are present, but so that it does not hinder development, it will not prevent the rest of the test suite from running, and will also not block PRs.

Notable fixes:

Many MPI subroutines contain preprocessor flags which result in unused variable errors when compiled without MPI. These have been fixed by adding checks which may be useful when a developer is developing/compiling in serial mode but adding MPI calls
Routines for radiation are under construction and have arguments that are not currently used. Rather than removing these arguments, dummy checks have been added to suppress the warnings.

conradtchan commented 3 months ago

@ryosuke-hirai please feel free to suggest alternative ways of fixing some of these compiler warnings if you think my changes are a bit clunky.

Also, if you disagree with the "zero-warning" approach or don't want to run a CI to check it, that's also completely fine. This is mostly a matter of personal preference.

ryosuke-hirai commented 3 months ago

I don't disagree with the "zero-warning" approach. I was meaning to work on removing this at some point anyway so thanks for cleaning things up.

The temporary suppresses are fine to me but can you put "TEMPORARY" in the comments so I can efficiently find them later when the additional features are put in?

conradtchan commented 3 months ago

Sure, I've added some comments in: https://github.com/ryosuke-hirai/HORMONE/pull/54/commits/dd7fefabb633be7f14fc0a6f0d7008714b2d2c37

ryosuke-hirai commented 3 months ago

Thanks!

ryosuke-hirai / HORMONE

Fix gfortran compiler warnings #54