search

rzane / file_store

🗄️ A unified interface for file storage backends
MIT License
19 stars 3 forks source link

Use S3 virtual hosts #15

Closed rzane closed 4 years ago

rzane commented 4 years ago

This removes the :region and :base_url options from the S3 adapter. We're able to gather this information by reading the configuration from ExAws.

This PR contains two breaking changes to FileStore.Adapters.S3.get_signed_url/3:

  1. Only the :expires_in option will be passed along to ExAws. All other options will be thrown away. This is to facilitate future work to abstract these options.
  2. The virtual_host: true option is being passed to ExAws.