Closed warmwaffles closed 2 years ago
I still need to throw some tests up on here for S3, and will get to that later this evening.
@rzane this is read to be looked at now. I added :type
to the file stat so when the content type is grabbed from the store it can set a reasonable content type. I settled on application/octet-stream
because that's what amazon returns when the content type is not specified, and it's a generic enough type that we should be fine.
Should we add :disposition
to the file stat? I'm unsure on that addition.
If it's useful to someone, I'm not opposed to adding it. But, for now, I think we can leave it out.
ExAws.S3 allows sending :content_type and :content_disposition when putting objects into storage. Other options are allowed, but in order to keep consistent with the current FileStore interface, we are only going to allow
:content_type
and:disposition
to be sent.https://hexdocs.pm/ex_aws_s3/ExAws.S3.html#put_object/4