search

rzane / file_store

🗄️ A unified interface for file storage backends
MIT License
19 stars 3 forks source link

Adds `stream!/3` interface #34

Open warmwaffles opened 3 months ago

warmwaffles commented 3 months ago

This is a rough draft of what I think the stream implementation should be like. I do not know how I am going to test the error case where the file can not be found with any of the adapters. The exception happens in a supervised storage implementation that is inside of a macro for the adapter cases.

I'm looking for some feedback on this while I work through this.

Closes #33

warmwaffles commented 3 months ago

@rzane I'd like your input on this implementation thus far before I start hammering on it more.

warmwaffles commented 3 months ago

@rzane I made some changes here. I still need to fix my local Minio and make sure the S3 adapter is working how I want it to.