search

s-kostyaev / ellama

Ellama is a tool for interacting with large language models from Emacs.
GNU General Public License v3.0
378 stars 27 forks source link

feat: add ellama-make-flash-cards #10

Open geekodour opened 8 months ago

geekodour commented 8 months ago

Adds function to create flashcards from selected text in the buffer

s-kostyaev commented 8 months ago

Hi, @geekodour. Thank you for this PR. Have you signed the FSF copyright assignment (CA)? I have a plan to move this project to GNU Elpa and all significant contributors should do it for that. Since this PR contains more than 15 loc, it matters. Sorry, that this not in Readme yet.

s-kostyaev commented 8 months ago

I have tried it, nice feature, thank you for contributing!

s-kostyaev commented 8 months ago

Also, maybe it will be more useful if generation result will be in file in customized directory instead of ellama chat buffer? Or you mean later interactions with ellama about generated flash cards?

geekodour commented 8 months ago

I think ellama-instant would be more appropriate but it's not accessible from my config as it's not auto-loaded?(was that intentional?)

I think ellama-instant makes more sense than ellama-chat because chat would have previous context and I would in the usecase of generating flashcard not want it to include previous context as I might be switching between different files which don't relate to each other.

On top of that sometimes it takes repeated attempts for it to respond as expected. (Eg. sometimes it'll return with not the response we want but re-running works etc., for all these usecase.

Otherwise, chat is also nice in the way that we could tell it to generate a flashcard somewhat differently in any case. (But everytime we trigger ellama-make-flash-cards it should be a fresh chat context, that I think we should ensure for better results.

Let me know what you think will be a suitable thing to do here? :)

Also, I've sent the mail to FSF, will let you know when they get back.

s-kostyaev commented 8 months ago

If you need fresh context, I think ellama-instant will be better. It's not autoloaded because user doesn't need to use it interactively.

s-kostyaev commented 5 months ago

@geekodour Any updates? Or should we close this?