s-kostyaev / ellama

Ellama is a tool for interacting with large language models from Emacs.
GNU General Public License v3.0
492 stars 30 forks source link

:recycle: Refactor ellama.el code for improved response handling. #3

Closed jiahut closed 11 months ago

jiahut commented 11 months ago

I encountered some issues while using ellama.el in a Windows 10 environment. After fixing them, it was able to function properly.

There were two main issues:

  1. By default, curl outputs progress to the process, which needs to be removed.
  2. When outputting a long text, there may be a problem of disorder when inserting. This can be solved by moving to the end before inserting each time.

Thank you again for providing this tool, which allows for efficient communication with LLM in emacs.

s-kostyaev commented 11 months ago

Thank you for PR. I will check if it works in my environment later today. Also even if I merge it, it will be temporary solution. I have rewriting to use llm library, instead of call curl. See opened PR.

s-kostyaev commented 11 months ago

Fix comments, rebase on the fresh main and I will merge it. Well done 👍

jiahut commented 11 months ago

Fix comments, rebase on the fresh main and I will merge it. Well done 👍

@s-kostyaev Based on your comment, a code has been submitted.

s-kostyaev commented 11 months ago

Thank you!