s-kostyaev / ellama

Ellama is a tool for interacting with large language models from Emacs.
GNU General Public License v3.0
359 stars 25 forks source link

Factor out callback in ellama-chat to a separate named #43

Closed tvraman closed 6 months ago

tvraman commented 6 months ago

function so it can be advised or extended by external packages like Emacspeak.

Stebalien commented 6 months ago

Are you sure you don't want a hook instead? This function is only the default behavior.

s-kostyaev commented 6 months ago

I think hook will be better.

tvraman commented 6 months ago

I think eventually we want both.

Starting from desired behavior:

  1. The spoken/auditory feedback needs to be specific to a given type of interaction, so for chat you want to speak the response, for code-review or completion, the desired behavior will be different.

    1. So let's experiment with various approaches; addressing it via the default handler was just step 0.

--

s-kostyaev commented 6 months ago

Let's try this approach. Thank you @tvraman