search

s-kostyaev / ellama

Ellama is a tool for interacting with large language models from Emacs.
GNU General Public License v3.0
348 stars 25 forks source link

Context element #94

Closed r0man closed 3 months ago

r0man commented 3 months ago

Hi @s-kostyaev ,

this PR tries to make adding context elements extendable. I refactored the existing functionality to use EIEIO objects and defined generic functions to extract, format and add context elements. With this is was able to add documents I receive from my own knowledge base. Those documents are EIEIO objects/structs and I specialized the way they are rendered as well.

What do you think of this?

Roman

Ps. I sent my paperwork to the FSF. So I'm now waiting for a response.

s-kostyaev commented 3 months ago

Hi @r0man,

Thank you for opening this PR. This looks promising. I need more time to look into it. And this is definitely major contribution, so we need to wait until your paperwork will be done.

r0man commented 3 months ago

Hi @s-kostyaev, did you had a chance to look into this PR? My FSF paperwork is now completed.

r0man commented 3 months ago

I just resolved the conflicts we had with the main branch.

s-kostyaev commented 3 months ago

@r0man thank you!

r0man commented 3 months ago

Hi @s-kostyaev, thanks for merging an cutting a release!