Closed lowlyocean closed 4 years ago
Great! Please provide documentation for testing and webpack. It's still not clear for me how to use webpackchunks names.
Have added commit with updates to relevant documentation. The webpackChunkName is so that there are some recognizable names rather than numeric IDs (see red underline). Similarly [chunkhash] in webpack.common.js will force browser to download latest result of npm run dev
if there are changes to corresponding source code (see green underline).
Please enable requirement for tests to succeed in order for Pull Request to be eligible for merge. [For users forking the boilerplate into GitLab, see this instead]
.gitlab-ci.yml should be synchronized with .github/workflows/test.yml
Recommend to add the missing tests to auth.spec.js
Recommend to add spec.js test for each example module in the Dashboard (have provided inbox.spec.js as incomplete example)
The .eslintrc.json is perhaps too lenient, but without these rules the existing codebase would have failed static analysis
Probably worth to mention these new items in the Readme
Launching the auth.spec.js integration test using![ezgif-5-e846adc3381c](https://user-images.githubusercontent.com/13685818/86319231-0cdd2f00-bc02-11ea-87c5-a06c166f6d40.gif)
npx cypress open
in order to view step-by-step results: