search

saasitive / django-react-boilerplate

DIY Django + React Boilerplate for starting your SaaS
https://saasitive.com
MIT License
596 stars 89 forks source link

typo error in tutorial #3

Closed moreaupascal56 closed 2 years ago

moreaupascal56 commented 3 years ago

Hey Team :) First thanks a lot for the tutorial, I am at 4th step and just wanted to tell yoiu that there is a typo error in the tuto https://saasitive.com/tutorial/react-token-based-authentication-django/ Capture in // frontend/src/components/SignupReducer.js there is subimted instead of submitted, i have no idea if this is important but that's it! Also I had to install history 4.10.1 instead of 5.0.0

moreaupascal56 commented 3 years ago

btw I didn't know how to contact you other than github :)

pplonski commented 3 years ago

@moreaupascal56 thank you for reporting. Github is good place to report. With the next post I will fit this typo. Once again thank you!

moreaupascal56 commented 3 years ago

No problem ! I've found another small one : in this step django-rest-framework-email-verification. In the tests part when you are adding the 3 tests about re-sending the verification email : there is no mention that you should add the line resend_verification_url = '/api/v1/users/resend_activation/' in the #endpoints needed part, therefore the tests are failing at first. Anyway that is quite logical that we need this line but I still report it 👍 Capture

Once again the tuto is really well done it really makes understand well what we are doing 🥇