search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.33k stars 453 forks source link

Update PARI to version 2.5.0 #11130

Closed jdemeyer closed 12 years ago

jdemeyer commented 13 years ago

We need to add bugfixes for

  1. http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1147 (related to #9334)
  2. http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1153 (#10195)
  3. http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1154 (#11604)
  4. http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1184 (related to #9937)
  5. http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1185 (PARI bug discovered by a Sage doctest)
  6. http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1186 (PARI performance regression discovered by a Sage doctest)
  7. http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1187 (PARI bug discovered by a Sage doctest)
  8. http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1188 (PARI bug discovered by a Sage doctest)
  9. http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1192 (#10767)

We will do this by updating to PARI version 2.5.0, which is equal to svn revision 13228.

See also:

Apply:

  1. spkg http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p2.spkg (jdemeyer)
  2. spkg http://boxen.math.washington.edu/home/jdemeyer/spkg/lcalc-1.23.p9.spkg (from #11321)
  3. attachment: 11130_sagelib.patch (jdemeyer, cremona)
  4. attachment: 11130-sagelib-simon-v2.patch (cremona, jdemeyer)
  5. attachment: 11130_reviewer32.patch (jdemeyer)
  6. attachment: 11130-4.7.2.alpha3.patch (jdemeyer)
  7. attachment: 11130-4.8.alpha1.patch (jdemeyer)
  8. extcode patch attachment: 11130-extcode-v2.patch (cremona, jdemeyer)

Depends on #11321

Dependencies: #11321 (install this '''after''' building PARI)

CC: @mstreng @dimpase @jpflori

Component: packages: standard

Keywords: pari spkg sd32

Author: Jeroen Demeyer, John Cremona

Reviewer: John Cremona, Jeroen Demeyer, William Stein

Merged: sage-4.8.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/11130

jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -1,3 +1,7 @@
 We need to add bugfixes for
 1. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1147](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1147) (#9334)
 2. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1153](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1153) (#10195)
+
+However, since adding more and more patches to PARI is becoming unmaintainable, we simply should move to a more recent svn revision instead of revision 12623 (pari-2.4.3).
+
+Instead, we plan to update to svn revision 13065.
jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -5,3 +5,5 @@
 However, since adding more and more patches to PARI is becoming unmaintainable, we simply should move to a more recent svn revision instead of revision 12623 (pari-2.4.3).

 Instead, we plan to update to svn revision 13065.
+
+Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13065.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13065.p0.spkg)
jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -2,8 +2,8 @@
 1. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1147](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1147) (#9334)
 2. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1153](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1153) (#10195)

-However, since adding more and more patches to PARI is becoming unmaintainable, we simply should move to a more recent svn revision instead of revision 12623 (pari-2.4.3).
+However, since adding more and more patches to PARI is becoming unmaintainable, we simply should move to a more recent svn revision instead of revision 12623 (pari-2.4.3).  We plan to update to **svn revision 13065**.

-Instead, we plan to update to svn revision 13065.
+See also #10430 (previous PARI upgrade).

 Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13065.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13065.p0.spkg)
jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -1,8 +1,9 @@
 We need to add bugfixes for
 1. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1147](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1147) (#9334)
 2. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1153](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1153) (#10195)
+3. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1184](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1184) (related to #9937)

-However, since adding more and more patches to PARI is becoming unmaintainable, we simply should move to a more recent svn revision instead of revision 12623 (pari-2.4.3).  We plan to update to **svn revision 13065**.
+However, since adding more and more patches to PARI is becoming unmaintainable, we simply should move to a more recent svn revision instead of revision 12623 (pari-2.4.3).  We plan to update to **svn revision 13132**.

 See also #10430 (previous PARI upgrade).
jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -7,4 +7,4 @@

 See also #10430 (previous PARI upgrade).

-Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13065.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13065.p0.spkg)
+Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13132.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13132.p0.spkg)
jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -5,6 +5,6 @@

 However, since adding more and more patches to PARI is becoming unmaintainable, we simply should move to a more recent svn revision instead of revision 12623 (pari-2.4.3).  We plan to update to **svn revision 13132**.

-See also #10430 (previous PARI upgrade).
+See also #9343, #10430 (previous PARI upgrades).

 Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13132.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13132.p0.spkg)
jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -2,9 +2,10 @@
 1. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1147](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1147) (#9334)
 2. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1153](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1153) (#10195)
 3. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1184](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1184) (related to #9937)
+4. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1185](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1185) (discovered while working on this ticket)

-However, since adding more and more patches to PARI is becoming unmaintainable, we simply should move to a more recent svn revision instead of revision 12623 (pari-2.4.3).  We plan to update to **svn revision 13132**.
+However, since adding more and more patches to PARI is becoming unmaintainable, we simply should move to a more recent svn revision instead of revision 12623 (pari-2.4.3).  We plan to update to **svn revision 13144**.

 See also #9343, #10430 (previous PARI upgrades).

-Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13132.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13132.p0.spkg)
+Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13144.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13144.p0.spkg)
jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -9,3 +9,5 @@
 See also #9343, #10430 (previous PARI upgrades).

 Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13144.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13144.p0.spkg)
+
+Depends on #11230.
jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -3,8 +3,9 @@
 2. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1153](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1153) (#10195)
 3. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1184](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1184) (related to #9937)
 4. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1185](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1185) (discovered while working on this ticket)
+5. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1186](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1186) (discovered while working on this ticket)

-However, since adding more and more patches to PARI is becoming unmaintainable, we simply should move to a more recent svn revision instead of revision 12623 (pari-2.4.3).  We plan to update to **svn revision 13144**.
+However, since adding more and more patches to PARI is becoming unmaintainable, we simply should move to a more recent svn revision instead of revision 12623 (pari-2.4.3).  We plan to update to **svn revision 13151**.

 See also #9343, #10430 (previous PARI upgrades).
jdemeyer commented 13 years ago

Dependencies: #11230

jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -5,10 +5,10 @@
 4. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1185](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1185) (discovered while working on this ticket)
 5. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1186](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1186) (discovered while working on this ticket)

+We also include a fix from #10240 (pari-2.4.3.svn-12577.p9 incorrectly checks for the shared library on Cygwin).
+
 However, since adding more and more patches to PARI is becoming unmaintainable, we simply should move to a more recent svn revision instead of revision 12623 (pari-2.4.3).  We plan to update to **svn revision 13151**.

 See also #9343, #10430 (previous PARI upgrades).

 Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13144.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13144.p0.spkg)
-
-Depends on #11230.
jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -11,4 +11,4 @@

 See also #9343, #10430 (previous PARI upgrades).

-Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13144.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13144.p0.spkg)
+Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13151.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13151.p0.spkg)
jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -2,8 +2,10 @@
 1. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1147](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1147) (#9334)
 2. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1153](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1153) (#10195)
 3. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1184](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1184) (related to #9937)
-4. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1185](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1185) (discovered while working on this ticket)
-5. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1186](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1186) (discovered while working on this ticket)
+4. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1185](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1185) (PARI bug discovered by a Sage doctest)
+5. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1186](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1186) (PARI performance regression discovered by a Sage doctest)
+6. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1187](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1187) (PARI bug discovered by a Sage doctest)
+7. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1188](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1188) (PARI bug discovered by a Sage doctest)

 We also include a fix from #10240 (pari-2.4.3.svn-12577.p9 incorrectly checks for the shared library on Cygwin).
jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -9,8 +9,8 @@

 We also include a fix from #10240 (pari-2.4.3.svn-12577.p9 incorrectly checks for the shared library on Cygwin).

-However, since adding more and more patches to PARI is becoming unmaintainable, we simply should move to a more recent svn revision instead of revision 12623 (pari-2.4.3).  We plan to update to **svn revision 13151**.
+However, since adding more and more patches to PARI is becoming unmaintainable, we simply should move to a more recent svn revision instead of revision 12623 (pari-2.4.3).  We plan to update to **svn revision 13153**.

 See also #9343, #10430 (previous PARI upgrades).

-Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13151.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13151.p0.spkg)
+Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13153.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13153.p0.spkg)
JohnCremona commented 13 years ago
comment:17

I am currently testing this. To avoid duplication of effort, I'll fix things I find in the elliptic_curves directory only.

JohnCremona commented 13 years ago
comment:18

After (1) Building a fresh 4.7.alpha5 from scratch, (2) installing the spkg lined here with "sage -f", (3) applying the patch here to the sage library and (4) running "sage -b", I find that the Sage build will not start up properly:

ImportError                               Traceback (most recent call last)
...

/home/jec/sage-4.7.alpha5.11130/local/lib/python2.6/site-packages/sage/misc/functional.py in <module>()
     36 
     37 
---> 38 from sage.rings.complex_double import CDF
     39 from sage.rings.real_double import RDF, RealDoubleElement
     40 

/home/jec/sage-4.7.alpha5.11130/local/bin/gen.pxd in init sage.rings.complex_double (sage/rings/complex_double.c:15178)()

ImportError: /home/jec/sage-4.7.alpha5.11130/local/lib/python2.6/site-packages/sage/libs/pari/gen.so: undefined symbol: defaultOut
Error importing ipy_profile_sage - perhaps you should run %upgrade?
WARNING: Loading of ipy_profile_sage failed.

so I cannot test anything.

Did I do something wrong?

jdemeyer commented 13 years ago
comment:19

Replying to @JohnCremona:

Did I do something wrong?

This ticket depends on #11230.

JohnCremona commented 13 years ago
comment:20

Replying to @jdemeyer:

Replying to @JohnCremona:

Did I do something wrong?

This ticket depends on #11230.

I see! I'll have some time to spend on this tomorrow (Monday) so I'll have another go.

jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -14,3 +14,5 @@
 See also #9343, #10430 (previous PARI upgrades).

 Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13153.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13153.p0.spkg)
+
+All doctest failures related to *simon_two_descent* will be fixed in #11005 and should be *ignored* for this ticket.
jdemeyer commented 13 years ago

Changed dependencies from #11230 to #11230, #11234

jdemeyer commented 13 years ago
comment:22

Replying to @JohnCremona:

I am currently testing this. To avoid duplication of effort, I'll fix things I find in the elliptic_curves directory only.

Sounds good, I will look at everything else.

JohnCremona commented 13 years ago

Attachment: trac_11130-doctest-poly.patch.gz

Applies after previous

JohnCremona commented 13 years ago
comment:23

I added a patch which fixes the doctest failures in sage/rings/polynomial/polynomial_quotient_ring.py . In all cases the new output was equivalent to the old.

There are now just some failures in sage/schemes/elliptic_curves/ell_rational_field.py (2 doctests failed) and sage/schemes/elliptic_curves/ell_number_field.py (1 doctests failed).

JohnCremona commented 13 years ago
comment:24

ell_rational_field.py: only one failure, looks completely trivial but will be left until #11005 to be fixed.

ell_number_field.py: one failure, even more trivial: the final output is exactly the same as it was but the verbose output is a little different, so this can be easily cleaned up at #11005.

As far as I am concerned this needs no more work on this ticket, but I'll delay marking it positive review until the same is possible at #11005. Still, it certainly gets "needs review" on that basis.

JohnCremona commented 13 years ago

Reviewer: John Cremona

jdemeyer commented 13 years ago
comment:25

This patch should also be tested on various systems first, PARI is known to produce different results on 32-bit and 64-bit systems.

JohnCremona commented 13 years ago
comment:26

Replying to @jdemeyer:

This patch should also be tested on various systems first, PARI is known to produce different results on 32-bit and 64-bit systems.

Good point. I can test it on my 32-bit laptop.

jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -6,8 +6,7 @@
 5. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1186](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1186) (PARI performance regression discovered by a Sage doctest)
 6. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1187](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1187) (PARI bug discovered by a Sage doctest)
 7. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1188](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1188) (PARI bug discovered by a Sage doctest)
-
-We also include a fix from #10240 (pari-2.4.3.svn-12577.p9 incorrectly checks for the shared library on Cygwin).
+8. #10240 (pari-2.4.3.svn-12577.p9 incorrectly checks for the shared library on Cygwin).  We simply use the spkg patch from that ticket.

 However, since adding more and more patches to PARI is becoming unmaintainable, we simply should move to a more recent svn revision instead of revision 12623 (pari-2.4.3).  We plan to update to **svn revision 13153**.
jdemeyer commented 13 years ago

Work Issues: Test on various systems

jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -12,6 +12,8 @@

 See also #9343, #10430 (previous PARI upgrades).

+See also #10247 (Sage 4.6 has PARI problems on Cygwin).
+
 Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13153.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13153.p0.spkg)

 All doctest failures related to *simon_two_descent* will be fixed in #11005 and should be *ignored* for this ticket.
jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -11,9 +11,10 @@
 However, since adding more and more patches to PARI is becoming unmaintainable, we simply should move to a more recent svn revision instead of revision 12623 (pari-2.4.3).  We plan to update to **svn revision 13153**.

 See also #9343, #10430 (previous PARI upgrades).
-
 See also #10247 (Sage 4.6 has PARI problems on Cygwin).

 Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13153.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13153.p0.spkg)

+Apply [attachment: 11130_sagelib.patch](https://github.com/sagemath/sage-prod/files/10652575/11130_sagelib.patch.gz) and [attachment: trac_11130-doctest-poly.patch](https://github.com/sagemath/sage-prod/files/10652570/trac_11130-doctest-poly.patch.gz).
+
 All doctest failures related to *simon_two_descent* will be fixed in #11005 and should be *ignored* for this ticket.
jdemeyer commented 13 years ago

Changed work issues from Test on various systems to Test on various systems with #10247 applied

jdemeyer commented 13 years ago
comment:31

In sage/rings/number_field/number_field.py, there is a test which fails only when -long is not used.

jdemeyer commented 13 years ago
comment:32

New patch fixes the long time issue (by setting a random seed explicitly). I will test on a Mac OS X 10.4 32-bit PPC system.

jdemeyer commented 13 years ago

Changed author from Jeroen Demeyer to Jeroen Demeyer, John Cremona

JohnCremona commented 13 years ago
comment:34

Testing now on a 32-bit ubuntu system.

JohnCremona commented 13 years ago
comment:35

Replying to @JohnCremona:

Testing now on a 32-bit ubuntu system.

... which gave several more failures:

    sage -t  devel/sage-main/sage/rings/number_field/number_field.py # 1 doctests failed
    sage -t  devel/sage-main/sage/schemes/elliptic_curves/ell_number_field.py # 2 doctests failed
    sage -t  devel/sage-main/sage/schemes/elliptic_curves/ell_rational_field.py # 1 doctests failed
    sage -t  devel/sage-main/sage/rings/number_field/number_field_element.pyx # 1 doctests failed
    sage -t  devel/sage-main/sage/rings/polynomial/polynomial_quotient_ring.py # 3 doctests failed
    sage -t  devel/sage-main/sage/rings/integer.pyx # 1 doctests failed

Details:

sage -t  "devel/sage-main/sage/rings/number_field/number_field.py"
**********************************************************************
File "/home/john/sage-4.7.alpha5/devel/sage-main/sage/rings/number_field/number_field.py", line 3616:
    sage: L.factor(a + 1)
Expected:
    (Fractional ideal (1/2*a*b + a + 1/2)) * (Fractional ideal (-1/2*b - 1/2*a + 1))
Got:
    (Fractional ideal (-1/2*a*b - a - 1/2)) * (Fractional ideal (1/2*b + 1/2*a - 1))

is trivial,

sage -t  "devel/sage-main/sage/rings/number_field/number_field_element.pyx"
**********************************************************************
File "/home/john/sage-4.7.alpha5/devel/sage-main/sage/rings/number_field/number_field_element.pyx", line 1142:
    sage: t = (2*a + b)._rnfisnorm(L); t[1]
Expected:
    (b - 2)*a + 2*b - 3
Got:
    (-4*b - 5)*a + 5*b + 6

needs looking at, 

sage -t  "devel/sage-main/sage/rings/polynomial/polynomial_quotient_ring.py"

are just like the ones I fixed before on the other machine, and

sage -t  "devel/sage-main/sage/rings/integer.pyx"           
**********************************************************************
File "/home/john/sage-4.7.alpha5/devel/sage-main/sage/rings/integer.pyx", line 4389:
    sage: 7._bnfisnorm(CyclotomicField(7))
Expected:
    (-zeta7 + 1, 1)
Got:
    (-zeta7^5 + zeta7^4, 1)

is also trivial (multiplying by a power of zeta does not change the norm!).

That's all I have time for today, so I hope things look similar on the other 32-bit system being tested.

JohnCremona commented 13 years ago

Attachment: 11130_sagelib32.patch.gz

Apply after previous

JohnCremona commented 13 years ago
comment:36

I have added a new patch (which affects 4 files in sage/rings) after which all doctests pass on both 32- and 64-bit, apart from the simon-related ones.

That means that it is time to check #11005 on top of all this.

JohnCremona commented 13 years ago

Description changed:

--- 
+++ 
@@ -15,6 +15,6 @@

 Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13153.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13153.p0.spkg)

-Apply [attachment: 11130_sagelib.patch](https://github.com/sagemath/sage-prod/files/10652575/11130_sagelib.patch.gz) and [attachment: trac_11130-doctest-poly.patch](https://github.com/sagemath/sage-prod/files/10652570/trac_11130-doctest-poly.patch.gz).
+Apply [attachment: 11130_sagelib.patch](https://github.com/sagemath/sage-prod/files/10652575/11130_sagelib.patch.gz) and [attachment: trac_11130-doctest-poly.patch](https://github.com/sagemath/sage-prod/files/10652570/trac_11130-doctest-poly.patch.gz) and [11130_sagelib32.patch].

 All doctest failures related to *simon_two_descent* will be fixed in #11005 and should be *ignored* for this ticket.
jdemeyer commented 13 years ago

Changed work issues from Test on various systems with #10247 applied to none

jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -7,14 +7,15 @@
 6. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1187](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1187) (PARI bug discovered by a Sage doctest)
 7. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1188](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1188) (PARI bug discovered by a Sage doctest)
 8. #10240 (pari-2.4.3.svn-12577.p9 incorrectly checks for the shared library on Cygwin).  We simply use the spkg patch from that ticket.
+9. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1192](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1192) (#10767)

-However, since adding more and more patches to PARI is becoming unmaintainable, we simply should move to a more recent svn revision instead of revision 12623 (pari-2.4.3).  We plan to update to **svn revision 13153**.
+However, since adding more and more patches to PARI is becoming unmaintainable, we simply should move to a more recent svn revision instead of revision 12623 (pari-2.4.3).  We plan to update to **svn revision 13162**.

 See also #9343, #10430 (previous PARI upgrades).
 See also #10247 (Sage 4.6 has PARI problems on Cygwin).

 Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13153.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13153.p0.spkg)

-Apply [attachment: 11130_sagelib.patch](https://github.com/sagemath/sage-prod/files/10652575/11130_sagelib.patch.gz) and [attachment: trac_11130-doctest-poly.patch](https://github.com/sagemath/sage-prod/files/10652570/trac_11130-doctest-poly.patch.gz) and [11130_sagelib32.patch].
+Apply [attachment: 11130_sagelib.patch](https://github.com/sagemath/sage-prod/files/10652575/11130_sagelib.patch.gz) and [attachment: trac_11130-doctest-poly.patch](https://github.com/sagemath/sage-prod/files/10652570/trac_11130-doctest-poly.patch.gz) and [attachment: 11130_sagelib32.patch](https://github.com/sagemath/sage-prod/files/10652571/11130_sagelib32.patch.gz).

 All doctest failures related to *simon_two_descent* will be fixed in #11005 and should be *ignored* for this ticket.
jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -14,7 +14,7 @@
 See also #9343, #10430 (previous PARI upgrades).
 See also #10247 (Sage 4.6 has PARI problems on Cygwin).

-Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13153.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13153.p0.spkg)
+Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13162.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13162.p0.spkg)

 Apply [attachment: 11130_sagelib.patch](https://github.com/sagemath/sage-prod/files/10652575/11130_sagelib.patch.gz) and [attachment: trac_11130-doctest-poly.patch](https://github.com/sagemath/sage-prod/files/10652570/trac_11130-doctest-poly.patch.gz) and [attachment: 11130_sagelib32.patch](https://github.com/sagemath/sage-prod/files/10652571/11130_sagelib32.patch.gz).
jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -8,8 +8,8 @@
 7. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1188](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1188) (PARI bug discovered by a Sage doctest)
 8. #10240 (pari-2.4.3.svn-12577.p9 incorrectly checks for the shared library on Cygwin).  We simply use the spkg patch from that ticket.
 9. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1192](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1192) (#10767)
-
-However, since adding more and more patches to PARI is becoming unmaintainable, we simply should move to a more recent svn revision instead of revision 12623 (pari-2.4.3).  We plan to update to **svn revision 13162**.
+ 
+We will do this by updating to PARI version 2.4.4.BETA, which is equal to **svn revision 13169**.

 See also #9343, #10430 (previous PARI upgrades).
 See also #10247 (Sage 4.6 has PARI problems on Cygwin).
jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -14,8 +14,8 @@
 See also #9343, #10430 (previous PARI upgrades).
 See also #10247 (Sage 4.6 has PARI problems on Cygwin).

-Preliminary spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13162.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13162.p0.spkg)
+All doctest failures related to *simon_two_descent* will be fixed in #11005 and should be *ignored* for this ticket.
+
+Spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.p0.spkg)

 Apply [attachment: 11130_sagelib.patch](https://github.com/sagemath/sage-prod/files/10652575/11130_sagelib.patch.gz) and [attachment: trac_11130-doctest-poly.patch](https://github.com/sagemath/sage-prod/files/10652570/trac_11130-doctest-poly.patch.gz) and [attachment: 11130_sagelib32.patch](https://github.com/sagemath/sage-prod/files/10652571/11130_sagelib32.patch.gz).
-
-All doctest failures related to *simon_two_descent* will be fixed in #11005 and should be *ignored* for this ticket.
jdemeyer commented 13 years ago
comment:41

lcalc fails to build with the new PARI:

Lcommandline.cc: In function 'int main(int, char**)':
Lcommandline.cc:476:54: error: 'allocatemoremem' was not declared in this scope
Lcommandline.cc:403:16: warning: unused variable 'C' [-Wunused-variable]
Lcommandline.cc:38:9: warning: unused variable 'i' [-Wunused-variable]
In file included from ../include/L.h:537:0,
                 from ../include/Lcommandline.h:36,
                 from Lcommandline.cc:31:
../include/Lvalue.h: In member function 'Complex L_function<ttype>::find_delta(Complex, Double) [with ttype = int, Complex = std::complex<double>, Double = double]':
Lcommandline.cc:463:50:   instantiated from here
../include/Lvalue.h:37:21: warning: unused variable 'f2' [-Wunused-variable]
make[1]: *** [Lcommandline.o] Error 1
make[1]: Leaving directory `/usr/local/src/sage-4.7.alpha5/spkg/build/lcalc-20100428-1.23.p6/src/src'
make: *** [all] Error 2
Error building lcalc 'make'
JohnCremona commented 13 years ago
comment:42

Replying to @jdemeyer:

lcalc fails to build with the new PARI:

Mike Rubenstein needs to be made aware of this.

kiwifb commented 13 years ago
comment:43

What about genus2reduction? I am assuming John already made sure eclib is working.

JohnCremona commented 13 years ago
comment:44

Replying to @kiwifb:

What about genus2reduction? I am assuming John already made sure eclib is working.

A reasonable assumption, but...for a while now I have used Sage's Pari and NTL builds rather than building them myself independently, so I cannot yet confirm. (However, eclib's use of Pari is minimal, it's only for integer factorization.)

I am also preparing a new version of eclib, so I will combine these two tasks, though I don't have any time for this this week.

jdemeyer commented 13 years ago
comment:45

Replying to @JohnCremona:

Replying to @jdemeyer:

lcalc fails to build with the new PARI:

Mike Rubenstein needs to be made aware of this.

First I will see if I can fix the error and then send the patches to him.