Ramified extensions of general p-adic rings and fields

roed314 commented 7 years ago

We should have support for relative extensions of p-adic rings and fields. This is particularly useful for totally ramified extensions of unramified extensions of Qp, which will represent a general absolute extension of Qp.

Depends on #23221 Depends on #23228 Depends on #23471 Depends on #25908 Depends on #21994

CC: @saraedum @sagetrac-swewers @xcaruso

Component: padics

Keywords: sd87, padicIMA

Author: David Roe, Julian Rüth, Xavier Caruso

Branch/Commit: 319f6d4

Reviewer: Julian Rüth, Xavier Caruso, David Roe

Issue created by migration from https://trac.sagemath.org/ticket/23218

xcaruso commented 6 years ago

Changed branch from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

roed314 commented 6 years ago

Changed branch from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

xcaruso commented 6 years ago

Changed branch from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

roed314 commented 6 years ago

Changed branch from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

xcaruso commented 6 years ago

Changed branch from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

899d9f6 Extra doctests in morphism.pyx

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 5553da8 to 899d9f6

roed314 commented 6 years ago

Changed branch from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

8d06440 Fix sphinx problem

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 899d9f6 to 8d06440

roed314 commented 6 years ago

comment:71

All tests pass on our machines. Sending it to the patchbots.

roed314 commented 6 years ago

Author: David Roe, Julian Rüth, Xavier Caruso

roed314 commented 6 years ago

Reviewer: Julian Rüth, Xavier Caruso, David Roe

xcaruso commented 6 years ago

comment:72

There's still a bug with shifting:

sage: W.<a> = Zq(2^10,3)
sage: S.<x> = W[]
sage: OL.<pi> = W.extension(x^2 - 2*a*x + 2)
sage: OL(1) >> 1
a + pi + pi^3 + a*pi^4 + O(pi^5)

The last answer should be 0, I guess.

In any case, results are not coherent:

sage: (OL(1) >> 1) >> 1
(a^2 + 1) + a*pi + pi^2 + O(pi^4)
sage: OL(1) >> 2
O(pi^4)

xcaruso commented 6 years ago

Changed branch from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 8d06440 to 5ffb263

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

5ffb263 replace creduce by normalize

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

7e842e3 Avoid to call two times cremove

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 5ffb263 to 7e842e3

roed314 commented 6 years ago

Changed branch from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

xcaruso commented 6 years ago

Changed branch from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 7e842e3 to e156f7f

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`8654e79`	`Make several methods work (or raise a NotImplementedError) for extensions`
`e156f7f`	`Write a test suite for the shifting operator`

roed314 commented 6 years ago

Changed dependencies from #23221, #23228, #23471, #25908 to #23221, #23228, #23471, #25908, #21994

roed314 commented 6 years ago

Changed branch from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from e156f7f to b979df8

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

b979df8 Remove a sig_on/sig_off

xcaruso commented 6 years ago

Changed branch from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

roed314 commented 6 years ago

Changed branch from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

xcaruso commented 6 years ago

Changed branch from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

xcaruso commented 6 years ago

comment:85

I've found--and fixed--some bugs.

I'm not satisfied with this ticket. Positive review for me when patchbot is happy.

Last 10 new commits:

`9340a8a`	`Fix a corner case`
`4d6623d`	`Merge branch 't/21994/quo_rem_revision' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields`
`2975633`	`Add _quo_rem to lattice precision`
`cabb63e`	`Merge branch 'u/caruso/quo_rem_revision' of git://trac.sagemath.org/sage into t/21994/quo_rem_revision`
`4fed21f`	`Merge branch 't/21994/quo_rem_revision' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields`
`aacb4c2`	`Merge branch 'u/roed/ramified_extensions_of_general_p_adic_rings_and_fields' of trac.sagemath.org:sage into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields`
`0ea13c0`	`Fix two bugs: one in expansion, one in cshift`
`22840e5`	`Prevent _test_log to compute log(0)`
`87f4c43`	`Always creduce after cremove`
`b1a3236`	`Remove unwanted print statements`

xcaruso commented 6 years ago

Changed commit from b979df8 to b1a3236

roed314 commented 6 years ago

Changed branch from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

ecf1155 Fix _get_unit in CA_template.pxi

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from b1a3236 to ecf1155

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

b2d0d73 Fixing doctests

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from ecf1155 to b2d0d73

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from b2d0d73 to ab5aab4

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

ab5aab4 Fixing doctests and typos

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from ab5aab4 to 8576c59

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

8576c59 Change construction functors for p-adics, making pushouts work in towers

xcaruso commented 6 years ago

Changed branch from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

roed314 commented 6 years ago

Changed branch from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

xcaruso commented 6 years ago

Changed branch from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

roed314 commented 6 years ago

Changed branch from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

xcaruso commented 6 years ago

Changed branch from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

roed314 commented 6 years ago

Changed branch from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

fda2c7d Adding documentation and fixing minor issues

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 8576c59 to fda2c7d

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`46744d6`	`Make _quo_rem more easily accessible to the user`
`c0da7de`	`Update documentation`
`c8ae6a7`	`Move the generic implementation of _quo_rem back from 23218`
`9662550`	`Merge branch 'u/roed/quo_rem_revision' of git://trac.sagemath.org/sage into t/21994/quo_rem_revision`
`162b44d`	`Fixing doctests, bad argument in floordiv`
`dc2df56`	`Merge branch 't/21994/quo_rem_revision' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields`

sagemath / sage

Ramified extensions of general p-adic rings and fields #23218