Ramified extensions of general p-adic rings and fields

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.42k stars 477 forks source link

Ramified extensions of general p-adic rings and fields #23218

Closed roed314 closed 6 years ago

roed314 commented 7 years ago

We should have support for relative extensions of p-adic rings and fields. This is particularly useful for totally ramified extensions of unramified extensions of Qp, which will represent a general absolute extension of Qp.

Depends on #23221 Depends on #23228 Depends on #23471 Depends on #25908 Depends on #21994

CC: @saraedum @sagetrac-swewers @xcaruso

Component: padics

Keywords: sd87, padicIMA

Author: David Roe, Julian Rüth, Xavier Caruso

Branch/Commit: 319f6d4

Reviewer: Julian Rüth, Xavier Caruso, David Roe

Issue created by migration from https://trac.sagemath.org/ticket/23218

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from fda2c7d to dc2df56

xcaruso commented 6 years ago

Changed branch from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

xcaruso commented 6 years ago

Changed commit from dc2df56 to e639fae

xcaruso commented 6 years ago

comment:100

All tests pass! (But several plugins failed.)

We're almost done!

New commits:

`e7a5b08`	`Reduce further after remove`
`e639fae`	`Add keyword reduce_relative in cremove`

roed314 commented 6 years ago

comment:101

I think we're planning on ignoring the pyflakes plugin; that's a task for another ticket.

We did leave in the _unit debugging method for relative_ramified_FP.pyx. That should either get removed or documented.

I can finish this off in the next few days if you don't get a chance before your flight.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from e639fae to 319f6d4

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

319f6d4 Remove the debugging method _unit

xcaruso commented 6 years ago

comment:103

I removed the method _unit.

The plugin startup_module says:

startup_modules Failed
startup_modules -- 3 seconds

but I don't understand what's the problem.

New commits:

319f6d4 Remove the debugging method _unit

xcaruso commented 6 years ago

comment:104

The latest patchbot report reports failures, but I think that they are not related to this ticket. Do you agree?

roed314 commented 6 years ago

comment:105

I agree. And the startup_module is just checking that new modules aren't unintentionally added to Sage when they shouldn't be. Since we're intending to, it's no problem.

I think we're all set!

vbraun commented 6 years ago

Changed branch from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to 319f6d4