py3: final polishing of the last failing doctests

fchapoton commented 5 years ago

After #26212, there remains only a few failing doctests (not using any optional package).

Fixed:

1 in src/sage/tests/books/computational-mathematics-with-sagemath/graphtheory_doctest.py #28300
1 in src/sage/tests/books/computational-mathematics-with-sagemath/sol/graphtheory_doctest.py #28300
(A) 1 in src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py #28305
(D) 1 in src/sage/tests/cmdline.py #28320
(C) 1 in src/sage/symbolic/expression.pyx #28219 #28412
(K) 2 in src/sage/crypto/block_cipher/present.py #28403
(B) 7 in src/sage/combinat/root_system/weyl_group.py #27967 #28351
(E) 1 at line 597 in src/sage/libs/eclib/interface.py #28454 #28472
(G) src/sage/rings/polynomial/polynomial_rational_flint.pyx #28334 #28649
(H) 1 in src/sage/libs/singular/function.pyx #28622
(I) 2 in src/sage/numerical/backends/generic_backend.pyx #28622
(J) 4 in src/sage/repl/attach.py #28622

Those that are not yet handled are the following.

On several machines:

(F) 1 in src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py (not seen since some time. random ? could be ignored ?)

but not on these machines: macOS mojave (several different machines)

OS X only:

(K) 2 in src/sage/symbolic/expression.py #28489
(L) 1 in src/sage/numerical/linear_tensor_element.pyx #28559

Table summary:


Issue	ref. patchbot	ubuntu, debian	OS X
(F)	fail ?
(K)			fail (intermittent)
(L)			fail (intermittent)

CC: @vinklein @embray @jm58660 @timokau @jhpalmieri @dcoudert @Etn40ff @antonio-rojas

Component: python3

Issue created by migration from https://trac.sagemath.org/ticket/28298

fchapoton commented 5 years ago

Description changed:

--- 
+++ 
@@ -4,21 +4,19 @@

 - on some machines:

-```
- 'src/sage/libs/singular/function.pyx  # 1 doctest failed',
- 'src/sage/libs/eclib/interface.py # 1 (line 597)',
- 'src/sage/numerical/backends/generic_backend.pyx  # 2 doctests failed',
- 'src/sage/repl/attach.py  # 4 doctests failed',
- 'src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py  # 1 doctest failed',
-  'src/sage/rings/polynomial/polynomial_rational_flint.pyx',
-```
+- 'src/sage/libs/singular/function.pyx  # 1 doctest failed',
+- 'src/sage/libs/eclib/interface.py # 1 (line 597)',
+- 'src/sage/numerical/backends/generic_backend.pyx  # 2 doctests failed',
+- 'src/sage/repl/attach.py  # 4 doctests failed',
+- 'src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py  # 1 doctest failed',
+- 'src/sage/rings/polynomial/polynomial_rational_flint.pyx',
+

 - on all machines:

-```
- 'src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py  # 1 doctest failed',
- 'src/sage/combinat/root_system/weyl_group.py  # 7 doctests failed', #27967
- 'src/sage/symbolic/expression.pyx  # 1 doctest failed', #28219
- 'src/sage/tests/books/computational-mathematics-with-sagemath/graphtheory_doctest.py  # 1 doctest failed',
- 'src/sage/tests/books/computational-mathematics-with-sagemath/sol/graphtheory_doctest.py  # 1 doctest failed',
-```
+- 'src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py  # 1 doctest failed',
+- 'src/sage/combinat/root_system/weyl_group.py  # 7 doctests failed', #27967
+- 'src/sage/symbolic/expression.pyx  # 1 doctest failed', #28219
+- 'src/sage/tests/books/computational-mathematics-with-sagemath/graphtheory_doctest.py  # 1 doctest failed',
+- 'src/sage/tests/books/computational-mathematics-with-sagemath/sol/graphtheory_doctest.py  # 1 doctest failed',
+

fchapoton commented 5 years ago

Description changed:

--- 
+++ 
@@ -17,6 +17,6 @@
 - 'src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py  # 1 doctest failed',
 - 'src/sage/combinat/root_system/weyl_group.py  # 7 doctests failed', #27967
 - 'src/sage/symbolic/expression.pyx  # 1 doctest failed', #28219
-- 'src/sage/tests/books/computational-mathematics-with-sagemath/graphtheory_doctest.py  # 1 doctest failed',
-- 'src/sage/tests/books/computational-mathematics-with-sagemath/sol/graphtheory_doctest.py  # 1 doctest failed',
+- 'src/sage/tests/books/computational-mathematics-with-sagemath/graphtheory_doctest.py  # 1 doctest failed', #28300
+- 'src/sage/tests/books/computational-mathematics-with-sagemath/sol/graphtheory_doctest.py  # 1 doctest failed', #28300

jhpalmieri commented 5 years ago

Description changed:

--- 
+++ 
@@ -14,7 +14,7 @@

 - on all machines:

-- 'src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py  # 1 doctest failed',
+- 'src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py  # 1 doctest failed', #28305
 - 'src/sage/combinat/root_system/weyl_group.py  # 7 doctests failed', #27967
 - 'src/sage/symbolic/expression.pyx  # 1 doctest failed', #28219
 - 'src/sage/tests/books/computational-mathematics-with-sagemath/graphtheory_doctest.py  # 1 doctest failed', #28300

jhpalmieri commented 5 years ago

comment:6

Are all of the failures "on some machines" actually on the same machine? Can these be reproduced by anyone else?

fchapoton commented 5 years ago

comment:7

the flint one has been reported by several people on sage-release

jhpalmieri commented 5 years ago

comment:8

The flint one is strange, since flint doesn't depend on Python. So either the error occurs also in Python 2, or there is something strange going on with the flint interface.

kwankyu commented 5 years ago

Description changed:

--- 
+++ 
@@ -2,21 +2,22 @@

 Those that are not yet handled are:

-- on some machines:
+- 1 in src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py #28305
+- 7 in src/sage/combinat/root_system/weyl_group.py #27967
+- 1 in src/sage/symbolic/expression.pyx #28219
+- 1 in src/sage/tests/books/computational-mathematics-with-sagemath/graphtheory_doctest.py #28300
+- 1 in src/sage/tests/books/computational-mathematics-with-sagemath/sol/graphtheory_doctest.py #28300

-- 'src/sage/libs/singular/function.pyx  # 1 doctest failed',
-- 'src/sage/libs/eclib/interface.py # 1 (line 597)',
-- 'src/sage/numerical/backends/generic_backend.pyx  # 2 doctests failed',
-- 'src/sage/repl/attach.py  # 4 doctests failed',
-- 'src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py  # 1 doctest failed',
-- 'src/sage/rings/polynomial/polynomial_rational_flint.pyx',
+on all machines, and

+- 1 in src/sage/libs/singular/function.pyx
+- 1 at line 597 in src/sage/libs/eclib/interface.py
+- 2 in src/sage/numerical/backends/generic_backend.pyx
+- 4 in src/sage/repl/attach.py
+- 1 in src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py
+- src/sage/rings/polynomial/polynomial_rational_flint.pyx

-- on all machines:
+on some machines except 

-- 'src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py  # 1 doctest failed', #28305
-- 'src/sage/combinat/root_system/weyl_group.py  # 7 doctests failed', #27967
-- 'src/sage/symbolic/expression.pyx  # 1 doctest failed', #28219
-- 'src/sage/tests/books/computational-mathematics-with-sagemath/graphtheory_doctest.py  # 1 doctest failed', #28300
-- 'src/sage/tests/books/computational-mathematics-with-sagemath/sol/graphtheory_doctest.py  # 1 doctest failed', #28300
+- macOS mojave Mac Pro

mwageringel commented 5 years ago

comment:10

Maybe this is a stupid question, but are we sure that the errors that are unique to the patchbot are machine-specific (i.e. reproducible on that machine) or is there a chance this could be fixed by doing a clean install?

fchapoton commented 5 years ago

comment:11

I have just "make distclean" that precise patchbot machine. It is currently running, and we will see the results in 2 hours. This machine has a fairly stable configuration, and the remaining failing doctests have been there since many releases.

Some of these errors pass when each file is doctested alone. Some look like a mis-synchronized (pexpect ?) interface.

Of course, we will have to make the decision when we claim "all doctests pass", in spite of the remaining quantum noise..

fchapoton commented 5 years ago

Description changed:

--- 
+++ 
@@ -1,12 +1,15 @@
 After #26212, there remains only a few failing doctests (not using any optional package).
+
+Fixed:
+
+- 1 in src/sage/tests/books/computational-mathematics-with-sagemath/graphtheory_doctest.py #28300
+- 1 in src/sage/tests/books/computational-mathematics-with-sagemath/sol/graphtheory_doctest.py #28300

 Those that are not yet handled are:

 - 1 in src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py #28305
 - 7 in src/sage/combinat/root_system/weyl_group.py #27967
 - 1 in src/sage/symbolic/expression.pyx #28219
-- 1 in src/sage/tests/books/computational-mathematics-with-sagemath/graphtheory_doctest.py #28300
-- 1 in src/sage/tests/books/computational-mathematics-with-sagemath/sol/graphtheory_doctest.py #28300

 on all machines, and

fchapoton commented 5 years ago

Description changed:

--- 
+++ 
@@ -5,22 +5,26 @@
 - 1 in src/sage/tests/books/computational-mathematics-with-sagemath/graphtheory_doctest.py #28300
 - 1 in src/sage/tests/books/computational-mathematics-with-sagemath/sol/graphtheory_doctest.py #28300

-Those that are not yet handled are:
+Those that are not yet handled are the following.
+
+*On all machines*:

 - 1 in src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py #28305
 - 7 in src/sage/combinat/root_system/weyl_group.py #27967
 - 1 in src/sage/symbolic/expression.pyx #28219

-on all machines, and
+*On several machines*:

-- 1 in src/sage/libs/singular/function.pyx
 - 1 at line 597 in src/sage/libs/eclib/interface.py
-- 2 in src/sage/numerical/backends/generic_backend.pyx
-- 4 in src/sage/repl/attach.py
 - 1 in src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py
 - src/sage/rings/polynomial/polynomial_rational_flint.pyx

-on some machines except 
+but not on macOS mojave Mac Pro ?

-- macOS mojave Mac Pro
+*On the reference patchbot machine only ?*

+- 1 in src/sage/libs/singular/function.pyx
+- 2 in src/sage/numerical/backends/generic_backend.pyx
+- 4 in src/sage/repl/attach.py
+
+

fchapoton commented 5 years ago

Description changed:

--- 
+++ 
@@ -12,6 +12,7 @@
 - 1 in src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py #28305
 - 7 in src/sage/combinat/root_system/weyl_group.py #27967
 - 1 in src/sage/symbolic/expression.pyx #28219
+- 1 in src/sage/tests/cmdline.py #28320

 *On several machines*:

fchapoton commented 5 years ago

Description changed:

--- 
+++ 
@@ -9,23 +9,37 @@

 *On all machines*:

-- 1 in src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py #28305
-- 7 in src/sage/combinat/root_system/weyl_group.py #27967
-- 1 in src/sage/symbolic/expression.pyx #28219
-- 1 in src/sage/tests/cmdline.py #28320
+- (A) 1 in src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py #28305
+- (B) 7 in src/sage/combinat/root_system/weyl_group.py #27967
+- (C) 1 in src/sage/symbolic/expression.pyx #28219
+- (D) 1 in src/sage/tests/cmdline.py #28320

 *On several machines*:

-- 1 at line 597 in src/sage/libs/eclib/interface.py
-- 1 in src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py
-- src/sage/rings/polynomial/polynomial_rational_flint.pyx
+- (E) 1 at line 597 in src/sage/libs/eclib/interface.py
+- (F) 1 in src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py
+- (G) src/sage/rings/polynomial/polynomial_rational_flint.pyx

 but not on macOS mojave Mac Pro ?

 *On the reference patchbot machine only ?*

-- 1 in src/sage/libs/singular/function.pyx
-- 2 in src/sage/numerical/backends/generic_backend.pyx
-- 4 in src/sage/repl/attach.py
+- (H) 1 in src/sage/libs/singular/function.pyx
+- (I) 2 in src/sage/numerical/backends/generic_backend.pyx
+- (J) 4 in src/sage/repl/attach.py

+Table summary:

+|       |               |           |
+|-------|---------------|-----------|
+| Issue | ref. patchbot | laptop ch |
+|  (A)  |   fail   | fail   | 
+|  (B)  |   fail   | fail   | 
+|  (C)  |   fail   | fail   | 
+|  (D)  |   fail   | fail   | 
+|  (E)  |          | fail   | 
+|  (F)  |   fail   |        |
+|  (G)  |          | fail   | 
+|  (H)  |   fail   |        |
+|  (I)  |   fail   |        |
+|  (J)  |   fail   |        |

kwankyu commented 5 years ago

Description changed:

--- 
+++ 
@@ -20,7 +20,7 @@
 - (F) 1 in src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py
 - (G) src/sage/rings/polynomial/polynomial_rational_flint.pyx

-but not on macOS mojave Mac Pro ?
+but not on these machines: macOS mojave Mac Pro.

 *On the reference patchbot machine only ?*

fchapoton commented 5 years ago

comment:17

Please add your machine results in the table, to help understand the remaining errors.

jhpalmieri commented 5 years ago

Description changed:

--- 
+++ 
@@ -20,7 +20,7 @@
 - (F) 1 in src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py
 - (G) src/sage/rings/polynomial/polynomial_rational_flint.pyx

-but not on these machines: macOS mojave Mac Pro.
+but not on these machines: macOS mojave (several different machines)

 *On the reference patchbot machine only ?*

@@ -30,16 +30,16 @@

 Table summary:

-|       |               |           |
-|-------|---------------|-----------|
-| Issue | ref. patchbot | laptop ch |
-|  (A)  |   fail   | fail   | 
-|  (B)  |   fail   | fail   | 
-|  (C)  |   fail   | fail   | 
-|  (D)  |   fail   | fail   | 
-|  (E)  |          | fail   | 
-|  (F)  |   fail   |        |
-|  (G)  |          | fail   | 
-|  (H)  |   fail   |        |
-|  (I)  |   fail   |        |
-|  (J)  |   fail   |        |
+|       |               |           |      |
+|-------|---------------|-----------|------|
+| Issue | ref. patchbot | laptop ch | OS X |
+|  (A)  |   fail   | fail   | fail |
+|  (B)  |   fail   | fail   | fail |
+|  (C)  |   fail   | fail   | fail |
+|  (D)  |   fail   | fail   | fail |
+|  (E)  |          | fail   |      |
+|  (F)  |   fail   |        |      |
+|  (G)  |          | fail   |      |
+|  (H)  |   fail   |        |      |
+|  (I)  |   fail   |        |      |
+|  (J)  |   fail   |        |      |

jhpalmieri commented 5 years ago

comment:19

I have access to three different OS X Mojave machines: an iMac Pro, an iMac, and a MacBook Air, and I see the same failures on all three. I've updated the table correspondingly.

mwageringel commented 5 years ago

Description changed:

--- 
+++ 
@@ -30,9 +30,9 @@

 Table summary:

-|       |               |           |      |
-|-------|---------------|-----------|------|
-| Issue | ref. patchbot | laptop ch | OS X |
+|       |               |           |              |
+|-------|---------------|-----------|--------------|
+| Issue | ref. patchbot | laptop ch | OS X, CentOS |
 |  (A)  |   fail   | fail   | fail |
 |  (B)  |   fail   | fail   | fail |
 |  (C)  |   fail   | fail   | fail |

mwageringel commented 5 years ago

comment:20

Same results on two CentOS machines.

jhpalmieri commented 5 years ago

comment:21

Frédéric, if you have a machine with the flint problem, can you try to track it down? Eric G thought it dated back at least to 8.8.rc3, but I don't see that in his report on sage-release. Emmanuel first reported it for 8.9.beta2 and provided a report for 8.9.beta1 without this failure, so maybe it happened between 8.9.beta1 and 8.9.beta2.

Can you use git bisect to try to locate the problem? Could it have been #28048? (I don't see why, but I'm looking at the tickets merged in 8.9.beta2, trying to see what could possibly be related. Could accents in SAGE_LOCAL be causing this?)

egourgoulhon commented 5 years ago

comment:22

Replying to @fchapoton:

Please add your machine results in the table, to help understand the remaining errors.

For my laptop (Ubuntu 18.04.2, Core i7-6700HQ, 16 GB RAM), the results are identical to those marked as "laptop ch".

kwankyu commented 5 years ago

comment:23

I guess the OS of the machine is important to understand the failures. Then what OS are the reference patchbot and "laptop ch"?

jhpalmieri commented 5 years ago

comment:24

Replying to @jhpalmieri:

Frédéric, if you have a machine with the flint problem, can you try to track it down? Eric G thought it dated back at least to 8.8.rc3, but I don't see that in his report on sage-release. Emmanuel first reported it for 8.9.beta2 and provided a report for 8.9.beta1 without this failure, so maybe it happened between 8.9.beta1 and 8.9.beta2.

Oh, I see, the relevant folder wasn't in python3-known-passing-test.txt until 8.9.beta2, so it may have been failing for some time before that.

egourgoulhon commented 5 years ago

comment:25

Replying to @jhpalmieri:

Replying to @jhpalmieri:

Frédéric, if you have a machine with the flint problem, can you try to track it down? Eric G thought it dated back at least to 8.8.rc3, but I don't see that in his report on sage-release. Emmanuel first reported it for 8.9.beta2 and provided a report for 8.9.beta1 without this failure, so maybe it happened between 8.9.beta1 and 8.9.beta2.

Oh, I see, the relevant folder wasn't in python3-known-passing-test.txt until 8.9.beta2, so it may have been failing for some time before that.

Yes I confirm. I've still a working version of Python3 8.8.rc3 (on Ubuntu 18.04) and the flint issue is already there.

jhpalmieri commented 5 years ago

Description changed:

--- 
+++ 
@@ -18,7 +18,7 @@

 - (E) 1 at line 597 in src/sage/libs/eclib/interface.py
 - (F) 1 in src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py
-- (G) src/sage/rings/polynomial/polynomial_rational_flint.pyx
+- (G) src/sage/rings/polynomial/polynomial_rational_flint.pyx #28334

 but not on these machines: macOS mojave (several different machines)

jhpalmieri commented 5 years ago

comment:26

I don't have any solutions, but let's track the flint problem at #28334.

jhpalmieri commented 5 years ago

Description changed:

--- 
+++ 
@@ -30,9 +30,9 @@

 Table summary:

-|       |               |           |              |
-|-------|---------------|-----------|--------------|
-| Issue | ref. patchbot | laptop ch | OS X, CentOS |
+|       |               |                   |              |
+|-------|---------------|-------------------|--------------|
+| Issue | ref. patchbot | laptop ch, debian | OS X, CentOS |
 |  (A)  |   fail   | fail   | fail |
 |  (B)  |   fail   | fail   | fail |
 |  (C)  |   fail   | fail   | fail |

jhpalmieri commented 5 years ago

Description changed:

--- 
+++ 
@@ -10,7 +10,7 @@
 *On all machines*:

 - (A) 1 in src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py #28305
-- (B) 7 in src/sage/combinat/root_system/weyl_group.py #27967
+- (B) 7 in src/sage/combinat/root_system/weyl_group.py #27967 #28351
 - (C) 1 in src/sage/symbolic/expression.pyx #28219
 - (D) 1 in src/sage/tests/cmdline.py #28320

fchapoton commented 5 years ago

Description changed:

--- 
+++ 
@@ -4,15 +4,15 @@

 - 1 in src/sage/tests/books/computational-mathematics-with-sagemath/graphtheory_doctest.py #28300
 - 1 in src/sage/tests/books/computational-mathematics-with-sagemath/sol/graphtheory_doctest.py #28300
+- (A) 1 in src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py #28305
+- (D) 1 in src/sage/tests/cmdline.py #28320

 Those that are not yet handled are the following.

 *On all machines*:

-- (A) 1 in src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py #28305
 - (B) 7 in src/sage/combinat/root_system/weyl_group.py #27967 #28351
 - (C) 1 in src/sage/symbolic/expression.pyx #28219
-- (D) 1 in src/sage/tests/cmdline.py #28320

 *On several machines*:

@@ -22,7 +22,7 @@

 but not on these machines: macOS mojave (several different machines)

-*On the reference patchbot machine only ?*
+*On the reference patchbot machine (ubuntu) only ?*

 - (H) 1 in src/sage/libs/singular/function.pyx
 - (I) 2 in src/sage/numerical/backends/generic_backend.pyx
@@ -30,13 +30,11 @@

 Table summary:

-|       |               |                   |              |
-|-------|---------------|-------------------|--------------|
-| Issue | ref. patchbot | laptop ch, debian | OS X, CentOS |
-|  (A)  |   fail   | fail   | fail |
+|       |               |                |              |
+|-------|---------------|----------------|--------------|
+| Issue | ref. patchbot | ubuntu, debian | OS X, CentOS |
 |  (B)  |   fail   | fail   | fail |
 |  (C)  |   fail   | fail   | fail |
-|  (D)  |   fail   | fail   | fail |
 |  (E)  |          | fail   |      |
 |  (F)  |   fail   |        |      |
 |  (G)  |          | fail   |      |

jhpalmieri commented 5 years ago

comment:30

I expect (K) to fail on all machines due to the nature of the problem, but I've only tested on OS X.

jhpalmieri commented 5 years ago

Description changed:

--- 
+++ 
@@ -13,6 +13,7 @@

 - (B) 7 in src/sage/combinat/root_system/weyl_group.py #27967 #28351
 - (C) 1 in src/sage/symbolic/expression.pyx #28219
+- (K) 2 in src/sage/crypto/block_cipher/present.py #28403

 *On several machines*:

@@ -41,3 +42,5 @@
 |  (H)  |   fail   |        |      |
 |  (I)  |   fail   |        |      |
 |  (J)  |   fail   |        |      |
+
+

jhpalmieri commented 5 years ago

Description changed:

--- 
+++ 
@@ -12,7 +12,7 @@
 *On all machines*:

 - (B) 7 in src/sage/combinat/root_system/weyl_group.py #27967 #28351
-- (C) 1 in src/sage/symbolic/expression.pyx #28219
+- (C) 1 in src/sage/symbolic/expression.pyx #28219 #28412
 - (K) 2 in src/sage/crypto/block_cipher/present.py #28403

 *On several machines*:

fchapoton commented 5 years ago

comment:32

Got a patchbot report from another machine, with similar results as for the reference machine:

https://patchbot.sagemath.org/log/0/Ubuntu/18.04/x86_64/4.15.0-54-generic/petitbonum/2019-08-29%2012:45:45?short

namely

sage -t --long src/sage/symbolic/expression.pyx  # 1 doctest failed
sage -t --long src/sage/combinat/root_system/weyl_group.py  # 7 doctests failed
sage -t --long src/sage/rings/polynomial/polynomial_rational_flint.pyx  # 1 doctest failed
sage -t --long src/sage/libs/eclib/interface.py  # 1 doctest failed
sage -t --long src/sage/crypto/block_cipher/present.py  # 2 doctests failed
sage -t --long src/sage/repl/attach.py  # 4 doctests failed
sage -t --long src/sage/libs/singular/function.pyx  # 1 doctest failed
sage -t --long src/sage/numerical/backends/generic_backend.pyx  # 2 doctests failed

fchapoton commented 5 years ago

Description changed:

--- 
+++ 
@@ -6,13 +6,13 @@
 - 1 in src/sage/tests/books/computational-mathematics-with-sagemath/sol/graphtheory_doctest.py #28300
 - (A) 1 in src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py #28305
 - (D) 1 in src/sage/tests/cmdline.py #28320
+- (C) 1 in src/sage/symbolic/expression.pyx #28219 #28412

 Those that are not yet handled are the following.

 *On all machines*:

 - (B) 7 in src/sage/combinat/root_system/weyl_group.py #27967 #28351
-- (C) 1 in src/sage/symbolic/expression.pyx #28219 #28412
 - (K) 2 in src/sage/crypto/block_cipher/present.py #28403

 *On several machines*:

fchapoton commented 5 years ago

comment:34

one fixed in 8.9.b9

fchapoton commented 5 years ago

Description changed:

--- 
+++ 
@@ -7,13 +7,13 @@
 - (A) 1 in src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py #28305
 - (D) 1 in src/sage/tests/cmdline.py #28320
 - (C) 1 in src/sage/symbolic/expression.pyx #28219 #28412
+- (K) 2 in src/sage/crypto/block_cipher/present.py #28403

 Those that are not yet handled are the following.

 *On all machines*:

 - (B) 7 in src/sage/combinat/root_system/weyl_group.py #27967 #28351
-- (K) 2 in src/sage/crypto/block_cipher/present.py #28403

 *On several machines*:

fchapoton commented 5 years ago

comment:35

rather two, in fact

kwankyu commented 5 years ago

Description changed:

--- 
+++ 
@@ -35,7 +35,6 @@
 |-------|---------------|----------------|--------------|
 | Issue | ref. patchbot | ubuntu, debian | OS X, CentOS |
 |  (B)  |   fail   | fail   | fail |
-|  (C)  |   fail   | fail   | fail |
 |  (E)  |          | fail   |      |
 |  (F)  |   fail   |        |      |
 |  (G)  |          | fail   |      |

7822f248-ba56-45f1-ab3d-4de7482bdf9f commented 5 years ago

comment:37

At this point, it begins to be useful to widen the scope of our checks. I proceeded to make ptestalllong on two different machines (but very close), with a few optional packages, both running 8.9.beta9.

//Please let me know if this isn't the right place to post this kind of reports...//

TL;DR:

make ptestalllong gives failures on 22 packages total (20 on one machine, 19 on the other);
Most of these failure cannot be reproduced when running the test standalone (whether MAKE is defined or not). Three file persist to fail when ran standalone:
- src/sage/combinat/root_system/weyl_group.py (known)
- src/sage/libs/eclib/interface.py (also known)
- src/sage/tests/gap_packages.py (not known but optional package, fails only on one of my machines).

I have no explanation for the intermachines differences; one is a Debian testing desktop (core i7, 8 GB RAM), the other is a Debian testing laptop (core i7, 16 GB RAM).

The large number of transient failures let me think that some parts of the libraries are not as reentrant as we might wish them to be...

Details of failing files:

| Test file                                               | Laptop | Desktop | Standalone |
|---------------------------------------------------------+--------+---------+------------|
| src/sage/graphs/generators/smallgraphs.py               | Y      | N       | N          |
| src/sage/combinat/posets/posets.py                      | Y      | Y       | N          |
| src/sage/combinat/root_system/weyl_group.py             | Y      | Y       | Y          |
| src/sage/plot/animate.py                                | Y      | Y       | N          |
| src/sage/doctest/forker.py                              | Y      | N       | N          |
| src/sage/libs/eclib/interface.py                        | Y      | Y       | Y          |
| src/sage/combinat/matrices/hadamard_matrix.py           | Y      | Y       | N          |
| src/sage/rings/polynomial/polynomial_rational_flint.pyx | Y      | Y       | N          |
| src/sage/symbolic/integration/external.py               | Y      | Y       | N          |
| src/sage/misc/latex.py                                  | Y      | Y       | N          |
| src/sage/coding/databases.py                            | Y      | Y       | N          |
| src/sage/misc/persist.pyx                               | Y      | Y       | N          |
| src/sage/databases/oeis.py                              | Y      | Y       | N          |
| src/sage/tests/gap_packages.py                          | Y      | N       | Y          |
| src/sage/repl/load.py                                   | Y      | Y       | N          |
| src/sage/graphs/graph_latex.py                          | Y      | Y       | N          |
| src/sage/combinat/designs/ext_rep.py                    | Y      | N       | N          |
| src/sage/misc/remote_file.py                            | Y      | Y       | N          |
| src/sage/databases/findstat.py                          | Y      | Y       | N          |
| src/sage/interfaces/magma_free.py                       | N      | Y       | N          |
| src/sage/interfaces/mathematica.py                      | N      | Y       | N          |

Details on the failures on request (including the full logs...). HTH,

egourgoulhon commented 5 years ago

comment:38

Description modified according to the report https://groups.google.com/d/msg/sage-release/M1JjXhXfsU4/TuPETvGUAgAJ

egourgoulhon commented 5 years ago

Description changed:

--- 
+++ 
@@ -23,7 +23,7 @@

 but not on these machines: macOS mojave (several different machines)

-*On the reference patchbot machine (ubuntu) only ?*
+*On the reference patchbot machine (Ubuntu) and on Ubuntu 18.04 with `make ptestlong`*:

 - (H) 1 in src/sage/libs/singular/function.pyx
 - (I) 2 in src/sage/numerical/backends/generic_backend.pyx
@@ -38,8 +38,8 @@
 |  (E)  |          | fail   |      |
 |  (F)  |   fail   |        |      |
 |  (G)  |          | fail   |      |
-|  (H)  |   fail   |        |      |
-|  (I)  |   fail   |        |      |
-|  (J)  |   fail   |        |      |
+|  (H)  |   fail   | fail (ptestlong only) |      |
+|  (I)  |   fail   | fail (ptestlong only) |      |
+|  (J)  |   fail   | fail (ptestlong only) |      |

egourgoulhon commented 5 years ago

comment:39

Replying to @egourgoulhon:

Description modified according to the report https://groups.google.com/d/msg/sage-release/M1JjXhXfsU4/TuPETvGUAgAJ

See however #28334 comment:11 for a possible further update of the summary table.

jhpalmieri commented 5 years ago

comment:40

I may have accidentally found a fix for the eclib/interface.py problem. See #28454. Needs testing and, more importantly, some understanding of whether this is a valid fix.

jhpalmieri commented 5 years ago

Description changed:

--- 
+++ 
@@ -17,7 +17,7 @@

 *On several machines*:

-- (E) 1 at line 597 in src/sage/libs/eclib/interface.py
+- (E) 1 at line 597 in src/sage/libs/eclib/interface.py #28454
 - (F) 1 in src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py
 - (G) src/sage/rings/polynomial/polynomial_rational_flint.pyx #28334

fchapoton commented 5 years ago

Description changed:

--- 
+++ 
@@ -31,9 +31,9 @@

 Table summary:

-|       |               |                |              |
-|-------|---------------|----------------|--------------|
-| Issue | ref. patchbot | ubuntu, debian | OS X, CentOS |
+|       |                       |                |              |
+|-------|-----------------------|----------------|--------------|
+| Issue | ref. patchbot (atlas) | ubuntu, debian | OS X, CentOS |
 |  (B)  |   fail   | fail   | fail |
 |  (E)  |          | fail   |      |
 |  (F)  |   fail   |        |      |

fchapoton commented 5 years ago

Description changed:

--- 
+++ 
@@ -23,7 +23,7 @@

 but not on these machines: macOS mojave (several different machines)

-*On the reference patchbot machine (Ubuntu) and on Ubuntu 18.04 with `make ptestlong`*:
+*On the reference patchbot machine (named atlas, running Ubuntu 16.04.6) and on Ubuntu 18.04 with `make ptestlong`*:

 - (H) 1 in src/sage/libs/singular/function.pyx
 - (I) 2 in src/sage/numerical/backends/generic_backend.pyx
@@ -31,9 +31,9 @@

 Table summary:

-|       |                       |                |              |
-|-------|-----------------------|----------------|--------------|
-| Issue | ref. patchbot (atlas) | ubuntu, debian | OS X, CentOS |
+|       |               |                |              |
+|-------|---------------|----------------|--------------|
+| Issue | ref. patchbot | ubuntu, debian | OS X, CentOS |
 |  (B)  |   fail   | fail   | fail |
 |  (E)  |          | fail   |      |
 |  (F)  |   fail   |        |      |

jhpalmieri commented 5 years ago

Description changed:

--- 
+++ 
@@ -17,7 +17,7 @@

 *On several machines*:

-- (E) 1 at line 597 in src/sage/libs/eclib/interface.py #28454
+- (E) 1 at line 597 in src/sage/libs/eclib/interface.py #28454 #28472
 - (F) 1 in src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py
 - (G) src/sage/rings/polynomial/polynomial_rational_flint.pyx #28334

jhpalmieri commented 5 years ago

Description changed:

--- 
+++ 
@@ -8,12 +8,9 @@
 - (D) 1 in src/sage/tests/cmdline.py #28320
 - (C) 1 in src/sage/symbolic/expression.pyx #28219 #28412
 - (K) 2 in src/sage/crypto/block_cipher/present.py #28403
+- (B) 7 in src/sage/combinat/root_system/weyl_group.py #27967 #28351

 Those that are not yet handled are the following.
-
-*On all machines*:
-
-- (B) 7 in src/sage/combinat/root_system/weyl_group.py #27967 #28351

 *On several machines*:

@@ -34,7 +31,6 @@
 |       |               |                |              |
 |-------|---------------|----------------|--------------|
 | Issue | ref. patchbot | ubuntu, debian | OS X, CentOS |
-|  (B)  |   fail   | fail   | fail |
 |  (E)  |          | fail   |      |
 |  (F)  |   fail   |        |      |
 |  (G)  |          | fail   |      |

fchapoton commented 5 years ago

Description changed:

--- 
+++ 
@@ -15,7 +15,7 @@
 *On several machines*:

 - (E) 1 at line 597 in src/sage/libs/eclib/interface.py #28454 #28472
-- (F) 1 in src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py
+- (F) 1 in src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py (not seen since some time. random ? could be ignored ?)
 - (G) src/sage/rings/polynomial/polynomial_rational_flint.pyx #28334

 but not on these machines: macOS mojave (several different machines)
@@ -32,7 +32,7 @@
 |-------|---------------|----------------|--------------|
 | Issue | ref. patchbot | ubuntu, debian | OS X, CentOS |
 |  (E)  |          | fail   |      |
-|  (F)  |   fail   |        |      |
+|  (F)  |   fail ?       |        |      |
 |  (G)  |          | fail   |      |
 |  (H)  |   fail   | fail (ptestlong only) |      |
 |  (I)  |   fail   | fail (ptestlong only) |      |

jhpalmieri commented 5 years ago

Description changed:

--- 
+++ 
@@ -26,6 +26,10 @@
 - (I) 2 in src/sage/numerical/backends/generic_backend.pyx
 - (J) 4 in src/sage/repl/attach.py

+OS X only:
+
+- (K) 2 in src/sage/symbolic/expression.py #28489
+
 Table summary:

 |       |               |                |              |
@@ -37,5 +41,5 @@
 |  (H)  |   fail   | fail (ptestlong only) |      |
 |  (I)  |   fail   | fail (ptestlong only) |      |
 |  (J)  |   fail   | fail (ptestlong only) |      |
+|  (K)  |          |                       | fail (intermittent) |

-

sagemath / sage

py3: final polishing of the last failing doctests #28298