saif-ellafi / foundryvtt-minimal-ui

Foundry VTT Module. Configurable UI module, allows the user to hide, collapse or auto-hide components separately.
MIT License
13 stars 10 forks source link

Player List Block Audio and Video Controls #104

Closed brunocalado closed 1 year ago

brunocalado commented 1 year ago

Hi!

Minimal UI blocks the use of the controls from AV.

image

CaosFR commented 1 year ago

Same for me since update to foundry v10 and the latest version of minimal-ui. @saif-ellafi Do you think you can solve it ? @brunocalado I use this macro for hide/unhide of the player list in the meantime of a fix.

if (ui.players.rendered) {

ui.players.close();

} else {

ui.players.render(true);

}
brunocalado commented 1 year ago

Same for me since update to foundry v10 and the latest version of minimal-ui. @saif-ellafi Do you think you can solve it ? @brunocalado I use this macro for hide/unhide of the player list in the meantime of a fix.

if (ui.players.rendered) {

ui.players.close();

} else {

ui.players.render(true);

}

I'm moving to top or bottom to deal with this. But, this is a good solution.

CaosFR commented 1 year ago

@brunocalado How do you set the player list in other position ?

brunocalado commented 1 year ago

@brunocalado How do you set the player list in other position ?

Not the player list. The cams. You can move then to top/bottom

brunocalado commented 1 year ago

image

CaosFR commented 1 year ago

Oh the dock, yes of course, I know it :) Thanks.

saif-ellafi commented 1 year ago

Thank you @CaosFR and @brunocalado for supporting here - I have released 1.5.1 with these fixes and your suggestions for thinner dock. appreciated if you let me know if it works. I have done minimal maintenance :)

CaosFR commented 1 year ago

@saif-ellafi I have test your update, thanks for your working.

For the size of the dock it's working. For the player list it's not working, the player list is still above the dock and now the options of miniumal for the player list dont work to (size, behaviour). Sadly, for a strange reason the options for the foundry logo dont work now ! :(

Test : Back to default setting then configuration, uninstall / install your module, reboot server => no change Back to 1.5.0 => Solved

image

image

saif-ellafi commented 1 year ago

Hmmm @CaosFR - the logo I will see... but the player list is no problem for me. Are you sure you removed other conflicting UI modules or custom styles? image

saif-ellafi commented 1 year ago

I am not sure what is that button you have with a handshake

saif-ellafi commented 1 year ago

I have released 1.5.2 with some potential improvements, and fixed the logo issue with the camera dock enabled

saif-ellafi commented 1 year ago

For me it is working really well now. If there are still issues it is for sure a compatibility problem. I have disabled player list functionality when the camera is enabled, basically, so none of the functions will work but it will look normal without problems :)

CaosFR commented 1 year ago

The handshake come from ItemsPile. With the 1.5.2 the foundry logo options work now, thanks :)

The problem persist with the player list for me. All other module are disable. Custom CSS is disable to. I'm on foundry, dnd5e, minimal ui latest.

image

I think we need a other beta testeur like @brunocalado for verify if the problem come from me. Most of time it's beceause my system is in french.

jacksands commented 1 year ago

Same here, using alien system image

also hide completely also not working... image

saif-ellafi commented 1 year ago

dang... checking

jacksands commented 1 year ago

don't worry man! thanks for your amazing module!

we appreciate your effort!!!

saif-ellafi commented 1 year ago

Thanks, yeah. It really baffles me that it doesn't happen to me in 1.5.2 image

saif-ellafi commented 1 year ago

I think I got it, it has to do with the hotbar position, you too seem to have the hotbar on the right

saif-ellafi commented 1 year ago

Alright @brunocalado @jacksands @CaosFR -- It was much harder than I had originally thought :) I think I could fix it now, phew. I really hope so. Plenty of code changes, if you could take a look, really appreciated. Fixed on version 1.5.3

saif-ellafi commented 1 year ago

Ok, fixed for real in 1.5.4 , I hope!!!

jacksands commented 1 year ago

PERFECT!! Alone and with 92 modules active!!!

image

image

tks my friend!

saif-ellafi commented 1 year ago

have fun!!!

CaosFR commented 1 year ago

DnDIWin-PLATE-500x500

@saif-ellafi Thanks :)