saif-ellafi / foundryvtt-minimal-ui

Foundry VTT Module. Configurable UI module, allows the user to hide, collapse or auto-hide components separately.
MIT License
13 stars 10 forks source link

v11 bug #123

Closed andy-jones closed 1 year ago

andy-jones commented 1 year ago

Works until anything appears in the chat panel, then as soon as a card is posted to the chat the whole chat panel shifts upwards so that the top menu is no longer visible. Tested this with all other add-ons switched off, and on multiple systems. Running latest version of Foundry.

saif-ellafi commented 1 year ago

Hi @andy-jones - could you please post a screenshot of what you mean?

andy-jones commented 1 year ago

Yes, of course.

See screenshot 1 attached - all looks fine and normal.

Screenshot 2 shows that once a card appears in the chat, the whole panel shifts upwards and you can’t see the menu at the top.

Hope that makes sense!

On 18 Jun 2023, at 10:26 pm, Saif Addin @. @.>> wrote:

Hi @andy-jones https://github.com/andy-jones - could you please post a screenshot of what you mean?

— Reply to this email directly, view it on GitHub https://github.com/saif-ellafi/foundryvtt-minimal-ui/issues/123#issuecomment-1596273852, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDRPWFBPM26HZN77DBNNOLXL5W7TANCNFSM6AAAAAAZLEBINU. You are receiving this because you were mentioned.

saif-ellafi commented 1 year ago

Hi @andy-jones - Thanks for the attempt, but I think screenshot attachments don't work from email in your case, or can't see them. Any chance you post them here in GitHub?

andy-jones commented 1 year ago

Screenshot1

Screenshot2

andy-jones commented 1 year ago

there we go!

saif-ellafi commented 1 year ago

Thanks - that's super weird. I don't do anything to the chat. Will have to check if this is something with this specific system. Is this CoC?

saif-ellafi commented 1 year ago

Ah alright, got it. I could reproduce it, will investigate asap and fix. Thanks

andy-jones commented 1 year ago

Yes, that's CoC, but it also does it in other systems - I've tried it on MoSh (unofficial Mothership) and D&D5e too. Thanks for your hard work on this, it's a great module!

saif-ellafi commented 1 year ago

Hey @andy-jones fixed in 1.6.1 - Could you check?

andy-jones commented 1 year ago

Perfect! That seems to have fixed it! Thanks.

saif-ellafi commented 1 year ago

Sorry @andy-jones - I broke it again

andy-jones commented 1 year ago

ooops :D

saif-ellafi commented 1 year ago

@andy-jones fixed once again, I hope this time for good. Foundry v11 did some changes I needed to tweak more stuff to it.

andy-jones commented 1 year ago

All looks good to me. Thanks again.Sent from my iPhoneOn 23 Jun 2023, at 09:59, Saif Addin @.***> wrote: @andy-jones fixed once again, I hope this time for good. Foundry v11 did some changes I needed to tweak more stuff to it.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>