saif-ellafi / foundryvtt-minimal-ui

Foundry VTT Module. Configurable UI module, allows the user to hide, collapse or auto-hide components separately.
MIT License
13 stars 10 forks source link

[Feature Request] minimal change in Player list behaviour (possibility of hide active users) #128

Closed Fridan99 closed 6 months ago

Fridan99 commented 1 year ago

I was wondering if it is possible to hide the active players in the Player list behaviour.

Sometimes when you have several options in the left menu, and you have several active players, there are certain commands in the left bar that are locked behind the list.

img (Here you can see how the options found in the left menu, the lower ones, are hidden and inaccessible by the list of active players. The more active players, the more options are hidden). In this img i have set Click toggle option.

1 1

The only option currently is to Hide completely. But this permanently hides the list, making it inaccessible.

I was wondering if you could e.g. with the click toggle option hide and unhide the players (no matter if they are active or inactive). This would put a kind of middle point).

Always visible (as it works)

Auto-hide (as it works)

Click toggle (click to see the whole list, another click to hide the whole list, no matter if they are active or not). This would give a middle point, for those times when you need to access the player list behaviour, and for when you don't need to hide it from players and be able to access the options further down the left menu.

Hide completely (as it works)

saif-ellafi commented 1 year ago

Hi @Fridan99 - how does this look when you don't have Minimal-UI disabled? The problem is with having many buttons in the control here, and is duplicate of: https://github.com/saif-ellafi/foundryvtt-minimal-ui/issues/127

Fridan99 commented 1 year ago

Minimal UI enabled

Enabled

Minimal UI disabled (behind the behaviour list there is an unaccesible icon from the left bar menu)

1 11

Probably if the "click toggle" option from minimal UI could also hide active players as well, this little incident would be solved.

Click (show all) Another click (hide all)

Fridan99 commented 1 year ago

This seems to be a problem of... the more options you have in the left menu the lower the options appear, and the more active players connect, the more behaviour player's box increase in size .... at some point they end up meeting each other.

I don't think it's a problem of the minimal ui.... itself, I think it's a problem of the platform. Maybe minimal UI could get around that little bug, if it could hide the active players as well.

Currently the only way to get around this problem is with minimal ui enabled and completely hide behaviour list. If minimal ui is not enabled, then the other option is to disable the behaviour list.

saif-ellafi commented 1 year ago

@Fridan99 what I would like to make sure is to verify whether Foundry (without minimal-ui) does break long list of buttons into multiple columns. It could be the case that Minimal UI is breaking that functionality. Could we add all these buttons without Minimal UI to confirm?

Fridan99 commented 1 year ago

Minimal UI enabled

Enabled

Minimal UI disabled (behind the behaviour list there is an unaccesible icon from the left bar menu)

1 11

Probably if the "click toggle" option from minimal UI could also hide active players as well, this little incident would be solved.

Click (show all) Another click (hide all)

are these screenshots not useful?

Minimal ui on and off

saif-ellafi commented 1 year ago

I would like to reproduce it myself, because I feel Minimal UI does not set new columns like without. Could you suggest me modules that add these buttons so I can test?

Fridan99 commented 1 year ago

Sure... the problem appears in the left bar Token Control icon

Try to enable those modules:

Argon Combat Hud Splatter DFreds Convenient effects Moulinette (and all submodules) Stealthy Token Lean: Peek Around Corners Sequencer Yendor's Scene Actors . . you can also add Weather Fx module, that add another icon . To test, you should connect as well as pc's, about 3 or 4 pc's so that the list goes up and the "bug" is reproduced.

I'm on v10, but probably the bug will be reproduced in v11 as well, as all these modules are v11 compatible.

saif-ellafi commented 10 months ago

Please take a look after the next Minimal UI's release soon

Fridan99 commented 6 months ago

In 1.6.11 the little problem still exists :P

1 11

For now the only solution that exists to access to all buttoms is to set hide completely the player behaviour list, The downside is that the item piles and rest buttons are lost.

Fridan99 commented 6 months ago

omg, just found out that this is a problem when I use dnd5e UI. If I disable dnd5e UI the problem does not occur.

dnd5e ui https://gitlab.com/sasmira/dnd-ui