search

saif-ellafi / foundryvtt-minimal-ui

Foundry VTT Module. Configurable UI module, allows the user to hide, collapse or auto-hide components separately.
MIT License
13 stars 10 forks source link

Support for Card Hands List #130

Closed kristianserrano closed 12 months ago

kristianserrano commented 1 year ago

I received an issue for Card Hands List regarding layout when using Minimal UI. I was attempting to try to provide a solution in Card Hands List, but I think this might have to be a solution provided by Minimal UI instead.

The ID of the element is #card-hands-list-container, and its current size, margins, etc. are based on the Players List. I suspect whatever styles and event listeners you're applying to the Players List you can apply to the Card Hands List as well.

If there's anything you need from me, please let me know.

saif-ellafi commented 1 year ago

Hi @kristianserrano - sorry for the big delay. I will remove the fixed position property of the players list in Minimal UI's next release.

I've also noticed you take the player's width property for your cards list (thanks!), but when Minimal UI sets the player List to toggle mode (the default, game.settings.get('minimal-ui', 'playerList') === 'clicktoggle'), the text label is not properly hidden, plus it the cards list doesn't have a click event to expand it:

image

I would suggest to not use --players-width and always show your cards hand at full, or perhaps implement it in similar way to Minimal UI for maximum compatibility.

Best

kristianserrano commented 1 year ago

Thank you, @saif-ellafi ! I'll take a look into this soon. This all seems pretty easy to implement.

kristianserrano commented 12 months ago

I've issued a fix for this. Thanks for the help!