search

saif-ellafi / foundryvtt-minimal-ui

Foundry VTT Module. Configurable UI module, allows the user to hide, collapse or auto-hide components separately.
MIT License
13 stars 10 forks source link

Taskbar & Minimal UI Issue #52

Open KevinRichard-GM opened 3 years ago

KevinRichard-GM commented 3 years ago

It appears Minimal UI CSS is overriding Taskbar CSS to position the macro hotbar. This causes the macro hotbar to slide to its location set by Minimal UI instead of staying above the Taskbar when you mouse over it and then slides back up to be positioned over the Taskbar when you mouse away.

Overriding the importance of the hotbar CSS in the Taskbar module fixes the issue but it has to be hacked in every time there is an update.

Is it possible to have a Manual Vertical Pixel setting similar to the Manual Horizontal Pixel setting?

saif-ellafi commented 3 years ago

Hi @KevinRichard-GM Thanks for taking the time to report this issue. I am trying to understand what you describe, but I am failing in the attempt. Is there any chance you can point with a screenshot what you mean exactly?

KevinRichard-GM commented 3 years ago

image

KevinRichard-GM commented 3 years ago

The Taskbar module uses CSS to move the macro hotbar above its location at the bottom of the FoundryVTT screen. When you mouse over the macro hotbar (ex. to click a macro to run), the CSS of your module forces the macro hotbar to the bottom of the screen putting it behind the Taskbar. Only leaving the top portion of the macro hotbar visible above the Taskbar. Then once the Taskbar gets focus again it forces the macro hotbar back to the position in the screen shot above.

So by inserting !important after the #hotbar command in the config.js of the Taskbar module I can force the Taskbar's CSS to override the CSS control Minimal UI is trying to exert over the macro hotbar. The Taskbar module creator doesn't want to make that part of the standard build as it might cause other issues, so I'm left hacking it in every time there is an update.

If you could include a similar option for Manual Vertical Pixel control to set the location of the macro hotbar similar to the Manual Horizontal Pixel control I would think it would keep this from happening.

KevinRichard-GM commented 3 years ago

image

simulacrum-1 commented 3 years ago

One of my players uses a laptop so would love to use the minimal UI too but have the same issue as the Taskbar ends up making it a pop-down rather than a pop-up. A vertical setting would be great.

https://user-images.githubusercontent.com/68729767/135602008-c93490b8-caa5-4b36-ba90-37d27a3f908b.mp4

Orionox commented 2 years ago

Having the same issue

Doresain commented 2 years ago

Same issue here. An alternative (and maybe simpler) option would be to provide a 'default position' option for each element's position option that refrains from overwriting it's position via CSS (and thereby overwriting any changes other modules might be making).

sharkbruhaha commented 2 years ago

same issue in v9. Talked to Ripper and they said that they can not fix it on their end, it is something in Minimal UI that needs to be modified.

sharkbruhaha commented 1 year ago

bump?