saif-ellafi / foundryvtt-minimal-ui

Foundry VTT Module. Configurable UI module, allows the user to hide, collapse or auto-hide components separately.
MIT License
13 stars 10 forks source link

Argon Combat UI Interaction #64

Closed justinthejaguar closed 2 years ago

justinthejaguar commented 2 years ago

When I hit the cross-swords icon to bring up the Argon combat UI, the left panel opens. Nothing out of the ordinary in the console log when I do this. Version is 0.8.9

Fridan99 commented 2 years ago

The same thing happens to me, when I open the Argon hud the left panel appears and locked (i have the autohide option).... only happens when i activate/deactivate the hud (cross-swords), then when the hud is active it doesn't happen until you reactivate/deactivate again..... it can be unlock normally pressin in the red lock.. but it's a curious bug. 🤣 🤣 🤣 🤣 🤣

saif-ellafi commented 2 years ago

Thanks, I might be able to patch this today (add a rule-out exception for this specific module). Ideally modules shouldn't "simulate" clicks, but well for now it is the fastest patch I can think of.

It this Argon Combat UI module a popular module overall?

justinthejaguar commented 2 years ago

Is this Argon Combat UI module a popular module overall?

It only released on October 11, but imho it is one of the smoothest looking UI's I have seen for foundry. It is inspired by a D&D 5e video game hud and UI. The game is called Solasta. I can see it becoming very popular in that it is extremely helpful in teaching players how to play D&D 5e. As to how many downloads it has, you would need to ask theripper93. As to why he is resistant to changing his use of .click(), I am not certain. I am not well-versed enough to understand what else that might tie into with his module.

Fridan99 commented 2 years ago

Thanks, I might be able to patch this today (add a rule-out exception for this specific module). Ideally modules shouldn't "simulate" clicks, but well for now it is the fastest patch I can think of.

It this Argon Combat UI module a popular module overall?

I believe that yes, it is a module that is becoming very popular and is under continuous maintenance.

saif-ellafi commented 2 years ago

hehe thanks all. Yes, asking for popularity is not at all of relevance in terms of support, just curiosity on whether it was something out there part of D&D people toolsets :D Glad to see that and will check it out myself

saif-ellafi commented 2 years ago

@justinthejaguar @Fridan99 could you give me a hand? - In general any button you press on the left-side controls will "lock" the sidebar. So clicking the swords button which also is a control button, will lock the left-side bar.

The lock was made out of convenience, in order to switch between controls and to prevent the sidebar from auto-hiding when the user is working on the tools. To hide it again, the unlock button is to be pressed.

saif-ellafi commented 2 years ago

Ahh I see just the ripper explained to me that is the token-hud what is triggering it.

saif-ellafi commented 2 years ago

Just released 1.1.9 -- Thank you @Fridan99 and @justinthejaguar for reporting this. Please confirm if all look good!

Fridan99 commented 2 years ago

I can't automatically update minimal ui from 1.1.8 to 1.1.9

Foundry 0.8.9 6

saif-ellafi commented 2 years ago

Ouch... This V9... Ok. I have deleted the Foundry V9 release. Please wait about 5 minutes and let me know if works then! Thank you

justinthejaguar commented 2 years ago

This works perfectly on V0.8.9 for me. Thank you!

Fridan99 commented 2 years ago

This works perfectly on V0.8.9 for me. Thank you!

How did you update? manually? in the repository app I can't do it

justinthejaguar commented 2 years ago

I run mine using node.is on a raspberry pi. I just updated it in the module screen. Make sure to uninstall the version you downloaded earlier.

Fridan99 commented 2 years ago

Minimal ui 1.1.9 https://github.com/saif-ellafi/foundryvtt-minimal-ui/releases/download/1.1.9/module.json

Upgrade to this link, if anyone use 0.8.9 Foundry.... courtesy of the module author. Apparently it is not possible to update correctly from the app repository. Just paste in the Manifest URL and install.

saif-ellafi commented 2 years ago

Fixed