saif-ellafi / foundryvtt-minimal-ui

Foundry VTT Module. Configurable UI module, allows the user to hide, collapse or auto-hide components separately.
MIT License
13 stars 10 forks source link

BUG: Hotbar & player list positions too high #68

Closed GambetTV closed 2 years ago

GambetTV commented 2 years ago

For some reason the positions of the macro hotbar and player list has been raised several pixels from the default, and there doesn't seem to be a way to move it back down.

saif-ellafi commented 2 years ago

Hey @GambetTV Thanks! - Could you please check the recently released 1.3.0 build?? Assuming you are on V9. I patched that up before checking this issue.

Tobyn52 commented 2 years ago

Hello. I've done a bunch of testing, and it seems the culprit is Custom Hotbar. I tested the following combinations:

1. Minimal UI, Monk's Hotbar, Custom Hotbar Core hotbar ends up positioned higher and the to right. Minimal's hotbar repostioning doesn't work. Custom's hotbar repositioning doesn't work.

2. Minimal UI, Custom Hotbar Core hotbar ends up positioned slightly higher. Minimal's hotbar repositioning doesn't work. Custom's hotbar repositioning doesn't work.

3. Monk's Hotbar, Custom Hotbar Core hotbar ends up in same position as Test 1. Custom's hotbar repositioning doesn't work.

4. Minimal UI, Monk's Hotbar Everything works.

Not sure how helpful this is, but I figured I'd share my findings.

saif-ellafi commented 2 years ago

Hey @Tobyn52 - your conclusions are correct. Custom Hotbar is enforcing positioning on the core Hotbar. However on today's release I have provided a workaround. Ideally, the change should be on custom Hotbar but at least for now we can survive this way.

We won't be able to change Hotbar position though minimal UI while Custom Hotbar Is enabled, as it's enforcing rules. My recommendation honestly I'd to try to play with monks Hotbar which plays nice with other modules. You can even use my other module "drag anything to Hotbar" with them together :)

Let me know if the latest version works fine, which should at least not shake with custom Hotbar.

Farmeroz commented 2 years ago

This latest version is causing a problem now. The main hotbar now "mirror" up the top of the screen (FVTT 0.8.9) and it "flickers" when hovering over it and you can't see any tool tips etc. Reverted to previous version and everything works as expected.

saif-ellafi commented 2 years ago

Hmm what happened @Farmeroz - is this compatibility issue? Which version are you on?

Farmeroz commented 2 years ago

@saif-ellafi on FVTT 0.8.9 using Minimal UI 1.1.1.0 there is a glitch as follows:

image

Main hot bar at bottom "flickers" and appears at the top of the page (and any mouseover/tool-tip appears on the top one.

image

I have to show you two images because it flickers and you can't screen capture it with both showing at once, but that's what happens.

With FVTT V9, that doesn't happen, but the left side bar is no longer "minimal":

image

This is not a problem with FVTT 0.8.9

Both issues are not present in FVTT 0.8.9 or V9 when using Minimal UI 1.1.9

saif-ellafi commented 2 years ago

Thanks, but there must be a confusion. V9 does not wok with 1.1.9, Foundry V9 works with 1.2.0 or higher. Will take a look what is the issue here.

Farmeroz commented 2 years ago

Thanks, but there must be a confusion. V9 does not wok with 1.1.9, Foundry V9 works with 1.2.0 or higher. Will take a look what is the issue here.

Thanks. It's weird!

saif-ellafi commented 2 years ago

@Farmeroz the last image you posted happens when you use Minimal UI 1.1.X with Foundry V9.

For V9 you should use Minimal UI 1.4.1 which is the latest version.

The images above are clearly on Foundry 0.8.x, will check what is going on with Custom Hotbar

saif-ellafi commented 2 years ago

Yes confirmed 1.1.10 is broken with Custom Hotbar... I guess this is why I didn't want to support multiple versions of Minimal UI :( will see to fix it - because also custom hotbar is changing and evolving

Farmeroz commented 2 years ago

Thank you. I think support for 0.8.9 only needs to be for a little while until everyone can move to V9 when all other modules are available.

However, on The Forge, the latest version available is 1.1.1.0 it seems?

image

saif-ellafi commented 2 years ago

Yes, 1.1.10 is the last version for Foundry 0.8.9 , while 1.4.1 is the last version for V9 I am not sure how the Forge works with multiple version builds!

BTW: I found the issue you mentioned above - I have fixed it without a new release (I had forgotten a line of code). If you uninstall 1.1.10 and reinstall it again, it should now work!

You can use this Manifest: https://github.com/saif-ellafi/foundryvtt-minimal-ui/releases/download/1.1.10/module.json

Will also release a 1.1.11 just to make this clear for everyone

Farmeroz commented 2 years ago

Thanks, 1.1.10 from https://github.com/saif-ellafi/foundryvtt-minimal-ui/releases/download/1.1.10/module.json works perfectly in 0.8.9