search

saif-ellafi / foundryvtt-minimal-ui

Foundry VTT Module. Configurable UI module, allows the user to hide, collapse or auto-hide components separately.
MIT License
13 stars 10 forks source link

v9 #77

Closed brunocalado closed 2 years ago

brunocalado commented 2 years ago

Hi.

Please remove the foundry vtt warning. image

Replace "compatibleCoreVersion":"0.9.0" by "compatibleCoreVersion":"9"

saif-ellafi commented 2 years ago

Hi. I am not sure, this was made by choice. I cannot guarantee that if Foundry updates, Minimal UI will continue to work correctly. Any style change that Foundry makes in any V9 release could have a compatibility risk.

brunocalado commented 2 years ago

Hi. I am not sure, this was made by choice. I cannot guarantee that if Foundry updates, Minimal UI will continue to work correctly. Any style change that Foundry makes in any V9 release could have a compatibility risk.

Yes, I understand. But, the foundry add this because their plans is not make breaking changes in a major version (v9, v10, etc).

With their build system a module without something like "compatibleCoreVersion":"9" will always have the warning tag.

I don't think there is no risk in a very small bug, but I don't think it'll you break minimal ui.

docs: https://gitlab.com/foundrynet/foundryvtt/-/issues/5635

saif-ellafi commented 2 years ago

Done a few releases ago!