search

sailfishos / sailfish-secrets

BSD 3-Clause "New" or "Revised" License
24 stars 15 forks source link

[sailfish-secrets] Register types with appropriate meta type names. Contributes to JB#45215 #166

Closed chriadam closed 4 years ago

chriadam commented 4 years ago

This commit undoes some of the type registration naming done in 2d1f6f80 and further improves the namespacing and type registration to ensure that clients can use the required types unambiguously.

This change is source incompatible for clients using the types from QML, but sailfish-secrets is not allowed for harbour currently.

dcaliste commented 4 years ago

@chriadam thanks for clarifying these. It may break jolla-settings-accounts/extensions/ui/EmailCryptoKeySelection.qml where I use both Secret and Cryypto import without as-ing them, and I use also things like SecretsRequest.

I can test and propose a MR there to fix it.

blammit commented 4 years ago

Tested with Settings > Keys UI changes, LGTM.