User Authentication - Githubissues

saipat commented 5 years ago

[x] Backend: DB, model, controller, views
[x] Redux Loop: ajax, actions, reducer
[x] Presentational Components
[x] Styling
- [x] When errors are displayed, the input boxes should not move
[x] Smooth, bug free navigation
- [x] Login errors clears when switching from login form to sign up form (and vice-versa)
- [x] Going to a random route /#/oweiniouewbrviuwebv should redirect to either /, /login, or /signup
- [x] Errors should display for both /signup and/login.
- [x] Errors should clear when moving between /signup and /login.
[x] Adequate and appropriate seeds
- [x] Demo Login Works

saipat commented 5 years ago

Hey Cynthia, Completed all the User Authentication issue. What should I do next?

xnanodax commented 5 years ago

Hey Sai! Everything looks good. Two points of feedback

1) I can scroll down on the login/sign up form. Is that what you wanted? There is a lot of empty space.

2) When I go to a random route, the router did not redirect! (I unchecked the box above)

saipat commented 5 years ago

Hi Cynthia, fixed the routing issue and filled the space in the home page.

saipat / Eton