search

saltstack-formulas / iscsi-formula

Manage iSCSI Target and Initiator via SaltStack (FreeBSD & GNU/Linux)
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
8 stars 7 forks source link

Add iscsi.remove #1

Closed alxwr closed 7 years ago

alxwr commented 7 years ago

to remove once configured initiator(s) and target(s) and disable the service(s).

plus: minor bugfix in iscsi.target

javierbertoli commented 7 years ago

@alxwr, it LGTM, but mind you add some documentation in the README.rst file about this state?

alxwr commented 7 years ago

@javierbertoli good point! :-) I'll add documentation when my workload goes down a bit (which should be next week).

alxwr commented 7 years ago

@javierbertoli, I updated README.rst

0xf10e commented 7 years ago

:+1: I guess we're done here then.

javierbertoli commented 7 years ago

@alxwr did you read my last comment? The README says it removes the package, but the state does not do it. So I think we should either remove the package in the state file, or fix the README. We'd be done then. Do you agree?

alxwr commented 7 years ago

@javierbertoli My fingers were faster than my brain. The README.rst was incorrect. I fixed it. (ctld and iscsid are built into FreeBSD and can't be removed via pkgng.) We're done here! Thanks!

javierbertoli commented 7 years ago

Merged, thanks @alxwr !

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: