Error when restoring a file with targetcli on Suse OS

saltstack-formulas / iscsi-formula

Manage iSCSI Target and Initiator via SaltStack (FreeBSD & GNU/Linux)

Other

8 stars 7 forks source link

Closed juadk closed 5 years ago

juadk commented 5 years ago

In Suse OS, the comments include in /etc/target/saveconfig.json by man5.jinja causes an issue when you want to restore it.

Example: restoreconfig

noelmcloughlin commented 5 years ago

This is a formula bug - comments are not allowed in JSON. Maybe you could raise PR to fix.

juadk commented 5 years ago

Sorry I forgot to add the PR number here after submitted it.

noelmcloughlin commented 5 years ago

Thanks. Another PR would be really useful - no comments allowed in JSON - I merged your PR to unblock you on Suse.

saltstack-formulas-travis commented 4 years ago

:tada: This issue has been resolved in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: